GuidedTour referencing a VE-MW renamed class - viewPageTarget
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

modules/ext.guidedTour.lib/ext.guidedTour.lib.main.js: return $( '.ve-init-mw-viewPageTarget-saveDialog-slide-review' ).is( ':visible' );

	Subject	Repo	Branch	Lines +/-
	Remove dead reference to .ve-init-mw-viewPageTarget-saveDialog-slide-review	mediawiki/extensions/GuidedTour	master	+2 -10

Mentioned In: rEGTOd81c35be7f0c: Remove dead reference to .ve-init-mw-viewPageTarget-saveDialog-slide-review
rMEXTe6edbaf83687: Updated mediawiki/extensions Project: mediawiki/extensions/GuidedTour…

Krenair raised the priority of this task from to Needs Triage.

Krenair updated the task description. (Show Details)

Krenair subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Actually slide-review was removed in https://gerrit.wikimedia.org/r/#/c/81876/25 (October 2013)

There doesn't seem to be a clear replacement selector (there is ve-ui-mwSaveDialog, but that's not specific enough).

I'll just remove it for now, and we can add it back if we need it.

Change 243098 had a related patch set uploaded (by Mattflaschen):
Remove dead reference to .ve-init-mw-viewPageTarget-saveDialog-slide-review

Change 243098 merged by jenkins-bot:
Remove dead reference to .ve-init-mw-viewPageTarget-saveDialog-slide-review

Krenair closed this task as Resolved.Oct 2 2015, 2:48 PM

Krenair set Security to None.

Jdforrester-WMF triaged this task as Medium priority.Oct 5 2015, 7:44 PM

Jdforrester-WMF edited a custom field.