Page MenuHomePhabricator

GuidedTour referencing a VE-MW renamed class - viewPageTarget
Closed, ResolvedPublic1 Estimated Story Points

Description

modules/ext.guidedTour.lib/ext.guidedTour.lib.main.js: return $( '.ve-init-mw-viewPageTarget-saveDialog-slide-review' ).is( ':visible' );

Event Timeline

Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair added a subscriber: Krenair.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

There doesn't seem to be a clear replacement selector (there is ve-ui-mwSaveDialog, but that's not specific enough).

I'll just remove it for now, and we can add it back if we need it.

Change 243098 had a related patch set uploaded (by Mattflaschen):
Remove dead reference to .ve-init-mw-viewPageTarget-saveDialog-slide-review

https://gerrit.wikimedia.org/r/243098

Change 243098 merged by jenkins-bot:
Remove dead reference to .ve-init-mw-viewPageTarget-saveDialog-slide-review

https://gerrit.wikimedia.org/r/243098

Krenair assigned this task to Mattflaschen-WMF.
Krenair removed a project: Patch-For-Review.
Krenair set Security to None.