Page MenuHomePhabricator
Create Task
Maniphest T113456

[bug] Statement changes are not appearing in client wiki
Closed, ResolvedPublic
Actions

Description

Statement changes are not appearing in my recent changes for a connected item (that has what I think are relevant usages: O, S, T, X) nor is statement usage on my client page being updated with new snak value.

These are individual changes (no coalescing). changes to site links and terms (e.g. descriptions) do appear in recent changes. I have entity usage setup and have this issue with master.

I wonder if anyone else can reproduce this issue or maybe somehow something is wrong with my wiki setup.

Details

SubjectRepoBranchLines +/-
Update Wikidata - Do not filter affected pages by namespace.mediawiki/corewmf/1.26wmf23+1 -1
Update Wikidata - Do not filter affected pages by namespace.mediawiki/extensions/Wikidatawmf/1.26wmf22+14 -39
Do not filter affected pages by namespace.mediawiki/extensions/Wikibasewmf/1.26wmf22+10 -35
Do not filter affected pages by namespace.mediawiki/extensions/Wikibasemaster+10 -35
Update Wikidata - No longer ignore changes to statements when processing changes on the clientmediawiki/corewmf/1.26wmf23+1 -1
Update Wikidata - No longer ignore changes to statements when processing changes on the clientmediawiki/extensions/Wikidatawmf/1.26wmf22+47 -19
Update Wikidata - No longer ignore changes to statements when processing changes on the clientmediawiki/extensions/Wikidatamaster+47 -19
No longer ignore changes to statements when processing changes on the clientmediawiki/extensions/Wikibasewmf/1.26wmf22+42 -2
No longer ignore changes to statements when processing changes on the clientmediawiki/extensions/Wikibasemaster+42 -2
Customize query in gerrit

Related Objects

Event Timeline

aude created this task.Sep 23 2015, 8:52 AM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added projects: Wikidata, MediaWiki-extensions-WikibaseClient.
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2015, 8:52 AM
aude set Security to None.Sep 23 2015, 8:52 AM
aude added a subscriber: daniel.
daniel added a comment.Sep 23 2015, 10:01 AM

I suspect the reason is that the diff is empty, because the statement diff got suppressed. AffectedPagesFinder will then find nothing. I'll look into it.

daniel added a comment.Sep 23 2015, 11:52 AM

Confirmed: the fact that changes that only affect statements have an empty diff causes AffectedPagesFinder::getAffectedUsagesByPage to return an empty array.

To resolve this correctly, we need to again include information about the statement change in the EntityChange object. We should use a simplified diff for that, I'll file a ticket.

As a quick fix, I will rig AffectedPagesFinger to assume "other" usages to be affected if the diff is empty. This is a hack though.

daniel renamed this task from Statement changes are not appearing in client wiki to [bug] Statement changes are not appearing in client wiki.Sep 23 2015, 12:05 PM

Filed T113468 for a better solution.

gerritbot subscribed.Sep 23 2015, 12:11 PM

Change 240340 had a related patch set uploaded (by Daniel Kinzler):
No longer ignore changes to statements when processing changes on the client

https://gerrit.wikimedia.org/r/240340

gerritbot added a project: Patch-For-Review.Sep 23 2015, 12:11 PM
daniel claimed this task.Sep 23 2015, 12:11 PM
daniel triaged this task as Unbreak Now! priority.
daniel added a project: Wikidata-Sprint-2015-09-15.
daniel moved this task from Backlog to Review on the Wikidata-Sprint-2015-09-15 board.
daniel moved this task from incoming to in progress on the Wikidata board.
gerritbot added a comment.Sep 23 2015, 12:23 PM

Change 240340 merged by jenkins-bot:
No longer ignore changes to statements when processing changes on the client

https://gerrit.wikimedia.org/r/240340

Diffusion mentioned this in rMEXT7d84d9fc8493: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 23 2015, 12:23 PM
daniel mentioned this in rEWBAea531dec429c: No longer ignore changes to statements when processing changes on the client.Sep 23 2015, 12:23 PM
gerritbot added a comment.Sep 23 2015, 1:10 PM

Change 240356 had a related patch set uploaded (by JanZerebecki):
No longer ignore changes to statements when processing changes on the client

https://gerrit.wikimedia.org/r/240356

gerritbot added a comment.Sep 23 2015, 1:40 PM

Change 240356 merged by Hoo man:
No longer ignore changes to statements when processing changes on the client

https://gerrit.wikimedia.org/r/240356

JanZerebecki mentioned this in rEWBAfab4d7fdc1ac: No longer ignore changes to statements when processing changes on the client.Sep 23 2015, 1:40 PM
gerritbot added a comment.Sep 23 2015, 2:03 PM

Change 240364 had a related patch set uploaded (by JanZerebecki):
Update Wikidata - No longer ignore changes to statements when processing changes on the client

https://gerrit.wikimedia.org/r/240364

gerritbot added a comment.Sep 23 2015, 2:04 PM

Change 240364 abandoned by JanZerebecki:
Update Wikidata - No longer ignore changes to statements when processing changes on the client

Reason:
*sigh* Sorry. Wrong branch. Habbit of typing yes.

https://gerrit.wikimedia.org/r/240364

gerritbot added a comment.Sep 23 2015, 2:07 PM

Change 240365 had a related patch set uploaded (by JanZerebecki):
Update Wikidata - No longer ignore changes to statements when processing changes on the client

https://gerrit.wikimedia.org/r/240365

gerritbot added a comment.Sep 23 2015, 3:13 PM

Change 240365 merged by jenkins-bot:
Update Wikidata - No longer ignore changes to statements when processing changes on the client

https://gerrit.wikimedia.org/r/240365

JanZerebecki mentioned this in rMW98d40d527c11: Updated mediawiki/core Project: mediawiki/extensions/Wikidata….Sep 23 2015, 3:14 PM
JanZerebecki mentioned this in rMW98277a3233d1: Updated mediawiki/core Project: mediawiki/extensions/Wikidata….
JanZerebecki mentioned this in rEWDA9e5e7f5cc9a8: Update Wikidata - No longer ignore changes to statements when processing….Sep 23 2015, 3:18 PM
daniel added a comment.Sep 23 2015, 4:53 PM

Fix was backported and deployed during SWAT. However, I'm unable to confirm the fix - it seems to be still broken on the live site.
When testing locally, the fix works as expected.

gerritbot added a comment.Sep 23 2015, 5:42 PM

Change 240427 had a related patch set uploaded (by JanZerebecki):
Update Wikidata - No longer ignore changes to statements when processing changes on the client

https://gerrit.wikimedia.org/r/240427

gerritbot added a comment.Sep 23 2015, 5:43 PM

Change 240427 merged by Chad:
Update Wikidata - No longer ignore changes to statements when processing changes on the client

https://gerrit.wikimedia.org/r/240427

JanZerebecki mentioned this in rMWdc869a1268eb: Update Wikidata - No longer ignore changes to statements when processing….Sep 23 2015, 5:43 PM
daniel added a comment.Sep 23 2015, 5:58 PM

Still no Kittens.

JanZerebecki subscribed.Sep 23 2015, 7:24 PM

So @aude said that she could see a statement change in her watchlist ( https://www.wikidata.org/w/index.php?title=Q72096&type=revision&diff=253317600&oldid=239924844 ). It also shows up from https://ru.wikipedia.org/w/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%A1%D0%B2%D1%8F%D0%B7%D0%B0%D0%BD%D0%BD%D1%8B%D0%B5_%D0%BF%D1%80%D0%B0%D0%B2%D0%BA%D0%B8&hidewikidata=0&target=1924_%D0%B3%D0%BE%D0%B4 which links to the concepts ru page.

But https://www.wikidata.org/w/index.php?title=Q147&type=revision&diff=253312809&oldid=253304113 is not visible from https://en.wikipedia.org/w/index.php?title=Special:RecentChangesLinked&hidewikidata=0&target=Talk%3ANew_York_City%2FArchive_10 (it links to https://en.wikipedia.org/wiki/User:Aude ).

daniel added a comment.Sep 24 2015, 9:16 AM

Ugh. Found it. Patch upcoming.

We skip pages that are in a namespace for wiki wikibase is not "enabled". Though "enabled" just means for sitelinks, arbitrary access should work everywhere. When we decided that this should be the case, we forgot to remove the respective filter code from AffectedPagesFinder. And when testing the first patch, I didn't think to test main namespace and user namespace separately.

gerritbot added a comment.Sep 24 2015, 9:18 AM

Change 240655 had a related patch set uploaded (by Daniel Kinzler):
Do not filter affected pages by namespace.

https://gerrit.wikimedia.org/r/240655

gerritbot added a comment.Sep 24 2015, 11:00 AM

Change 240655 merged by jenkins-bot:
Do not filter affected pages by namespace.

https://gerrit.wikimedia.org/r/240655

daniel mentioned this in rEWBA4d2ff6c0cd1d: Do not filter affected pages by namespace..Sep 24 2015, 11:00 AM
daniel mentioned this in rMEXT4f40e4467e63: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….
gerritbot added a comment.Sep 24 2015, 12:08 PM

Change 240680 had a related patch set uploaded (by Daniel Kinzler):
Do not filter affected pages by namespace.

https://gerrit.wikimedia.org/r/240680

gerritbot added a comment.Sep 24 2015, 3:11 PM

Change 240680 merged by Thcipriani:
Do not filter affected pages by namespace.

https://gerrit.wikimedia.org/r/240680

daniel mentioned this in rEWBA99a228181dc1: Do not filter affected pages by namespace..Sep 24 2015, 3:11 PM
gerritbot added a comment.Sep 24 2015, 3:17 PM

Change 240711 had a related patch set uploaded (by JanZerebecki):
Update Wikidata - Do not filter affected pages by namespace.

https://gerrit.wikimedia.org/r/240711

gerritbot added a comment.Sep 24 2015, 3:41 PM

Change 240711 merged by jenkins-bot:
Update Wikidata - Do not filter affected pages by namespace.

https://gerrit.wikimedia.org/r/240711

JanZerebecki mentioned this in rMW39a830ba2b93: Updated mediawiki/core Project: mediawiki/extensions/Wikidata….Sep 24 2015, 3:41 PM
JanZerebecki mentioned this in rMWb89249808a5d: Updated mediawiki/core Project: mediawiki/extensions/Wikidata….
JanZerebecki mentioned this in rEWDA36e6275115b3: Update Wikidata - Do not filter affected pages by namespace..
gerritbot added a comment.Sep 24 2015, 3:49 PM

Change 240727 had a related patch set uploaded (by JanZerebecki):
Update Wikidata - Do not filter affected pages by namespace.

https://gerrit.wikimedia.org/r/240727

gerritbot added a comment.Sep 24 2015, 4:11 PM

Change 240727 merged by Thcipriani:
Update Wikidata - Do not filter affected pages by namespace.

https://gerrit.wikimedia.org/r/240727

JanZerebecki mentioned this in rMW6d85a1765234: Update Wikidata - Do not filter affected pages by namespace..Sep 24 2015, 4:11 PM
JanZerebecki closed this task as Resolved.Sep 24 2015, 4:22 PM
daniel added a comment.Sep 24 2015, 4:23 PM

\o/

JanZerebecki moved this task from Review to Done on the Wikidata-Sprint-2015-09-15 board.Sep 24 2015, 4:43 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 29 2015, 8:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits