regression: Imagemap fails with "Error: Image is invalid or non-existent." if caption has a 
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Spage
	Sep 25 2015, 7:51 PM

Description

I imported a page with an imagemap (Architectural Modules of MediaWiki) from a wiki running 1.24.1 to mw.org running early 1.26, and instead of the imagemap got a red

Error: Image is invalid or non-existent.

After fiddling with it (see bug case at https://www.mediawiki.org/wiki/User:SPage_%28WMF%29/imagemap_bug ) I determined the   in the image description line caused the problem:

<imagemap>
Image:RequestModules.svg|thumb|center|600px|Caption<br><small>More details</small>
</imagemap>

Workaround: remove the   and it works.

is this a parser change?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use Parsoid's HTML5-compliant helpers for HTML transformations	mediawiki/extensions/ImageMap	master	+70 -41

Customize query in gerrit

Related Objects

Mentioned In: T101652: Unclosed "Enlarge" <a> tag from thumbnail is leaking on Special:BookSources

Event Timeline

• Spage created this task.Sep 25 2015, 7:51 PM

• Spage raised the priority of this task from to Needs Triage.

• Spage updated the task description. (Show Details)

• Spage added projects: ImageMap, Regression.

• Spage moved this task to Backlog on the ImageMap board.

• Spage subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2015, 7:51 PM

• Spage updated the task description. (Show Details)Sep 25 2015, 7:56 PM

• Spage set Security to None.

The problem is at: line 97 of rEIMA/includes/ImageMap.php

It reads as: loadXML( $imageHTML )
That means: This part of the file parameter is supposed to contain XML.
Now it is fed with a   tag. XML is expecting a closing  tag (which is actually nonsense in HTML). Since there is no closing tag found loadXML() issues an error message and the extension beaks.

It works with XHTML   void element.

This has a side effect: loadXML() is turning   into  . Later the second one then is turned into   again by Wiki post-parsing Remex HTML cleanup.
Use a pair <div> </div> which produces a new line by block element.

I ran into this yesterday while editing and it peeved me very much. Luckily it's much easier to fix today than it was in 2015.

Change 850313 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/ImageMap@master] Use Parsoid's HTML5-compliant helpers for HTML transformations

https://gerrit.wikimedia.org/r/850313

gerritbot added a project: Patch-For-Review.Oct 28 2022, 4:27 AM

Change 850313 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@master] Use Parsoid's HTML5-compliant helpers for HTML transformations

https://gerrit.wikimedia.org/r/850313

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 25 2022, 8:01 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 25 2022, 8:30 PM

matmarex closed this task as Resolved.Nov 26 2022, 1:31 PM

matmarex mentioned this in T101652: Unclosed "Enlarge" <a> tag from thumbnail is leaking on Special:BookSources.Nov 26 2022, 1:38 PM

regression: Imagemap fails with "Error: Image is invalid or non-existent." if caption has a <br> Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

regression: Imagemap fails with "Error: Image is invalid or non-existent." if caption has a <br>
Closed, ResolvedPublic
Actions