Page MenuHomePhabricator

MonoBook.php source code too wide
Closed, DeclinedPublic

Description

What kind of computers do you use to write MonoBook.php? Browsing the
source code is too wide for my screen, and no I don't use a VT100 :-)
"Snob code width snubs One Laptop Per Child kids".

This (inefficiently) finds other long lined files:
$ set $(find * -name \*.php)
$ for i do perl -nwe 'BEGIN{$a=0}

$a=length()>$a?length():$a;END{print $a,"\t"}' $i;
echo $i;done|sort -nr

Version: 1.9.x
Severity: minor
OS: Linux
Platform: PC

Details

Reference
bz9475

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:38 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz9475.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

Line length is reduced when we refactor or rewrite code. It's a slow process,
but more effective than doing a massive re-shuffle, which causes lots of faux
diffs to appear all over the Subversion logs.

It's better now, if not perfect. Marking WORKSFORME.