Page MenuHomePhabricator

Missing title parameter in index.php incorrectly lists page-Main_Page CSS class
Closed, ResolvedPublic

Description

Author: titoxd.wikimedia

Description:
If the title parameter from a link to a wiki page (such as modifying
http://en.wikipedia.org/w/index.php?title=Band-stop_filter&oldid=120276487 to
http://en.wikipedia.org/w/index.php?oldid=120276487) causes the page to render
properly, with one exception: the title of the page and the contents of
[[MediaWiki:Tagline]] are removed. Ideally, missing the title parameter would be
transparent to the user.


Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/w/index.php?oldid=120276487

Details

Reference
bz9572

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:37 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz9572.
bzimport added a subscriber: Unknown Object (MLST).

For the avoidance of doubt, if the page has been moved in the meantime, should the
title rendered be that at the time the "oldid" was current, or the title to which it
corresponds now?

titoxd.wikimedia wrote:

(In reply to comment #1)

For the avoidance of doubt, if the page has been moved in the meantime, should the title rendered be that at the

time the "oldid" was current, or the title to which it corresponds now?

I don't think the old title is kept in the revision table, so it would have to be the new one.

titoxd.wikimedia wrote:

Actually, after looking at my local copy of MediaWiki, the revision table stores page.page_id, so theoretically, it
*could* point to an old title. That would be an additional query, and I'm not sure that it even is a good idea, so I
say the new (current) title should be ok.

No, that's the current title. Anyway that's completely irrelevant AND DOES NOT
BELONG on this bug.

The issue this bug is about is probably triggered by the custom CSS on
en.wikipedia.org that hides the title section for the Main Page.

With the title parameter missing, the default page title (Main Page) seems to be
getting used when building the special page class. That shouldn't be the case;
it should be using the actual title, same as everything else.

ayg wrote:

*** This bug has been marked as a duplicate of 7046 ***