Page MenuHomePhabricator
Create Task
Maniphest T116149

'cite_error_references_duplicate_key' error message is double-parsed
Closed, ResolvedPublic
Actions

Description

Since T114898, the 'cite_error_references_duplicate_key' error message is double-parsed. This is not obviously visible until you do something crazy like add wikitext links to it.

Details

SubjectRepoBranchLines +/-
Do not double-parse 'cite_error_references_duplicate_key' error messagemediawiki/extensions/Citewmf/1.27.0-wmf.3+1 -1
Do not double-parse 'cite_error_references_duplicate_key' error messagemediawiki/extensions/Citewmf/1.27.0-wmf.2+1 -1
Do not double-parse 'cite_error_references_duplicate_key' error messagemediawiki/extensions/Citemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Oct 21 2015, 11:56 AM
matmarex claimed this task.
matmarex raised the priority of this task from to High.
matmarex updated the task description. (Show Details)
matmarex added a project: Cite.
matmarex subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2015, 11:56 AM
gerritbot subscribed.Oct 21 2015, 11:58 AM

Change 247818 had a related patch set uploaded (by Bartosz Dziewoński):
Do not double-parse 'cite_error_references_duplicate_key' error message

https://gerrit.wikimedia.org/r/247818

gerritbot added a project: Patch-For-Review.Oct 21 2015, 11:58 AM
matmarex added a comment.Oct 21 2015, 11:59 AM

https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Category:Pages_with_incorrect_ref_formatting

matmarex added a subscriber: PrimeHunter.Oct 21 2015, 12:00 PM
gerritbot added a comment.Oct 21 2015, 2:20 PM

Change 247818 merged by jenkins-bot:
Do not double-parse 'cite_error_references_duplicate_key' error message

https://gerrit.wikimedia.org/r/247818

gerritbot added a comment.Oct 21 2015, 2:24 PM

Change 247840 had a related patch set uploaded (by Bartosz Dziewoński):
Do not double-parse 'cite_error_references_duplicate_key' error message

https://gerrit.wikimedia.org/r/247840

gerritbot added a comment.Oct 21 2015, 2:24 PM

Change 247841 had a related patch set uploaded (by Bartosz Dziewoński):
Do not double-parse 'cite_error_references_duplicate_key' error message

https://gerrit.wikimedia.org/r/247841

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 21 2015, 3:00 PM
gerritbot added a comment.Oct 21 2015, 3:13 PM

Change 247840 merged by jenkins-bot:
Do not double-parse 'cite_error_references_duplicate_key' error message

https://gerrit.wikimedia.org/r/247840

gerritbot added a comment.Oct 21 2015, 3:13 PM

Change 247841 merged by jenkins-bot:
Do not double-parse 'cite_error_references_duplicate_key' error message

https://gerrit.wikimedia.org/r/247841

matmarex closed this task as Resolved.Oct 21 2015, 3:25 PM
matmarex edited projects, added MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)); removed Patch-For-Review.
matmarex set Security to None.

Fixed and deployed.

matmarex mentioned this in T116346: Cite error: Link to help page not displayed in Chromium.Oct 22 2015, 11:56 PM
matmarex merged a task: T116346: Cite error: Link to help page not displayed in Chromium.
matmarex added a subscriber: ori.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL