Author: mn12
Description:
If an implementation of AuthPlugin returns true from autoCreate, and false from
allowChangePassword, then an error results when attempting to create the new
record for a user who successfully authenticates for the first time.
The trace is essentially:
- (line 357 of SpecialUserlogin.php) The user has successfully authenticated
but has an id of 0 and the AuthPlugin implementation has returned true from
autoCreate so a call is made to initUser to create the new local user record.
- (line 311 of SpecialUserlogin.php) initUser calls setPassword on the user
object as part of initializing it before saving it to the local database.
- (line 1332 of User.php) setPassword checks the AuthPlugin implementation and
sees that allowPasswordChange returns false. Therefore it throws an error.
Scenario: We authenticate remotely against LDAP. Our users can only change
their password using a central facility outside of the Wiki. We want new
accounts to be created in our Wiki for any user who has succesfully
authenticated, but we do not want them to maintain a password in the local Wiki
database. Therefore we implemented autoCreate to return true and
allowPasswordChange to return false in our AuthPlugin subclass.
Possible resolution:
Only call setPassword from initUser conditionally based on the return value from
the AuthPlugin subclass' implementation of allowPasswordChange.
Version: 1.9.x
Severity: normal
Platform: PC