getTitleProtection MSSQL Error MSSQL Error
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	EndlessCTE
	Nov 18 2015, 5:27 PM

Description

SELECT pt_user AS user,pt_reason AS reason,pt_expiry AS expiry,pt_create_perm AS permission FROM [mediawiki].[PREFIX_protected_titles] WHERE pt_namespace = '2' AND pt_title = 'Admin'

Query alias 'user' needs to be escaped using brackets.

Working Fix:
includes/title.php line ~2560

array(
	'[user]' => 'pt_user',
	'reason' => 'pt_reason',
	'expiry' => 'pt_expiry',
	'permission' => 'pt_create_perm'
),

Details

	Subject	Repo	Branch	Lines +/-
	Quote column name aliases	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T105728: MySQL field aliases in select() should use quoting

Event Timeline

EndlessCTE created this task.Nov 18 2015, 5:27 PM

EndlessCTE raised the priority of this task from to Medium.

EndlessCTE updated the task description. (Show Details)

EndlessCTE subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2015, 5:27 PM

EndlessCTE renamed this task from getTitleProtection MSSQL Error to loadRestrictions MSSQL Error.Nov 18 2015, 5:28 PM

EndlessCTE set Security to None.

EndlessCTE renamed this task from loadRestrictions MSSQL Error to getTitleProtection MSSQL Error MSSQL Error.Nov 18 2015, 5:34 PM

EndlessCTE updated the task description. (Show Details)

Thanks for taking a look at the code!

You are very welcome to use developer access to submit this as a Git branch directly into Gerrit which makes it easier to review it quickly.
If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader. Thanks again!