Page MenuHomePhabricator

#cargo_query HOLDS check is over inclusive
Closed, ResolvedPublic

Description

The regex expressions in CargoSQLQuery.php which check for the use of multi-value fields in #cargo_query calls are over-inclusive in that they match the field "book" and the field "bookworm" when the only field that would allow for multiple values is "book". Additionally the matches are case sensitive while table and column names in most databases are case-insensitive.

Event Timeline

EdHoo claimed this task.
EdHoo raised the priority of this task from to Medium.
EdHoo updated the task description. (Show Details)
EdHoo subscribed.

Change 257266 had a related patch set uploaded (by Ed Hoo):
[Cargo] Fix T120583: #cargo_query HOLDS check used in multi-value fields

https://gerrit.wikimedia.org/r/257266