Page MenuHomePhabricator
Create Task
Maniphest T120627

Remove JS adding/removing 'hover' CSS class, use :hover pseudoclass instead
Closed, ResolvedPublic
Actions

Description

This is about the UploadWizard extension.

Remove JS adding/removing 'hover' CSS class, use :hover pseudoclass instead.

To find places where this is used, search for addClass( 'hover' ) in JavaScript files and .hover in CSS files.

There seem to be two distinct places using this, one related to jquery.showThumbCtrl plugin, the other related to mw.UploadWizardUploadInterface class.

Details

SubjectRepoBranchLines +/-
Remove JS adding/removing 'hover' CSS class, use :hover pseudoclass insteadmediawiki/extensions/UploadWizardmaster+5 -36
Customize query in gerrit

Event Timeline

matmarex created this task.Dec 7 2015, 2:30 AM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: UploadWizard, good first task, Google-Code-In-2015.
matmarex subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptDec 7 2015, 2:30 AM
Restricted Application added subscribers: StudiesWorld, Steinsplitter, Aklapper. · View Herald Transcript
MarkTraceur triaged this task as Medium priority.Dec 7 2015, 4:09 PM
MarkTraceur subscribed.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptDec 7 2015, 4:09 PM
MarkTraceur added a project: Technical-Debt.Dec 7 2015, 4:09 PM
catding subscribed.Dec 11 2015, 5:06 PM
catding unsubscribed.
Aklapper updated the task description. (Show Details)Dec 16 2015, 1:49 PM
Aklapper set Security to None.

Imported as https://codein.withgoogle.com/tasks/6342270513053696/

Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 16 2015, 1:50 PM
matmarex added a project: Patch-For-Review.Dec 21 2015, 2:21 PM

https://gerrit.wikimedia.org/r/260327

gerritbot subscribed.Dec 21 2015, 2:51 PM

Change 260327 had a related patch set uploaded (by Ananay):
Remove JS adding/removing 'hover' CSS class, use :hover pseudoclass instead in UploadWizard (Wikimedia)

https://gerrit.wikimedia.org/r/260327

gerritbot added a comment.Dec 21 2015, 3:11 PM

Change 260327 merged by jenkins-bot:
Remove JS adding/removing 'hover' CSS class, use :hover pseudoclass instead

https://gerrit.wikimedia.org/r/260327

matmarex closed this task as Resolved.Dec 21 2015, 3:13 PM
matmarex assigned this task to ananayarora.
matmarex removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 21 2015, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits