Page MenuHomePhabricator

In gerrit, the submit button for the service deploy repos is gone
Closed, ResolvedPublic

Description

Recently, it seems something has changed, and now I cannot submit for merge, even though I can still give it +2.

https://gerrit.wikimedia.org/r/#/c/257300/
https://gerrit.wikimedia.org/r/#/c/257301/

Event Timeline

Yurik raised the priority of this task from to Unbreak Now!.
Yurik updated the task description. (Show Details)
Yurik added a project: Gerrit.
Yurik subscribed.
Yurik renamed this task from Unable to submit for merge a service deploy repo to In gerrit, the submit button for the service deploy repos is gone.Dec 7 2015, 1:57 PM
Yurik set Security to None.

I was going to fiddle around with ACLs to try to fix this, but it looks like you fixed it yourself?

@Krenair, no, i didn't really fix it - unless git push is now the proper way to do it )))

So you pushed the change, and that made gerrit mark it as merged?

Yurik claimed this task.

Clone ssh://gerrit.wikimedia.org/maps (obviously you'll need to have your proper gerrit username and port set up in SSH config) and git show 1e6bbaeaf4e9ecfbc932aa9c52e759f408f159d3. You should be able to view this on the web, however T120658: Project access history links broken
Basically I just changed the rules to allow maps-dev to submit to those repositories.