Page MenuHomePhabricator
Create Task
Maniphest T120887

missing cache invalidation for TemplateModule
Closed, ResolvedPublic
Actions

Description

Compare https://test.wikidata.org/wiki/Q537 with http://wikidata.beta.wmflabs.org/wiki/Q15905 . Currently both are on the same Wikibase version. But the first is missing some html and thus icons on edit buttons. Is fixed by clearing local storage.

Details

SubjectRepoBranchLines +/-
Implement cache invalidation for TemplateModulemediawiki/extensions/Wikibasewmf/1.27.0-wmf.8+45 -8
Implement cache invalidation for TemplateModulemediawiki/extensions/Wikibasemaster+45 -8
Customize query in gerrit

Event Timeline

JanZerebecki created this task.Dec 8 2015, 11:54 PM
JanZerebecki raised the priority of this task from to High.
JanZerebecki updated the task description. (Show Details)
JanZerebecki added projects: Wikidata-Sprint-2015-12-01, Regression, Wikidata.
JanZerebecki subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2015, 11:54 PM
JanZerebecki updated the task description. (Show Details)Dec 8 2015, 11:57 PM
JanZerebecki set Security to None.
hoo subscribed.Dec 9 2015, 12:44 AM

Both look fine to me (without additional purging), both logged in and out.

JanZerebecki closed this task as Declined.Dec 9 2015, 1:32 AM
JanZerebecki claimed this task.

It was solved by deleting the local storage resource loader key in my browser. Forgot to save the content of that key before deleting. Seems too weird a case (oddly the sitelinks were correct, the [] were not around the edit) to salvage this report as a ResourceLoader bug.

JanZerebecki changed the task status from Declined to Invalid.Dec 9 2015, 1:32 AM
Tobi_WMDE_SW moved this task from Proposed to Done on the Wikidata-Sprint-2015-12-01 board.Dec 9 2015, 9:23 AM
aude subscribed.Dec 9 2015, 10:35 AM

when i click edit (such as for editing labels or a statement) on https://test.wikidata.org/wiki/Q22, there are no icons for save / cancel

as a user, i shouldn't have to do anything to my local storage. i'm not exactly sure what the problem is here :/

JanZerebecki reopened this task as Open.Dec 9 2015, 12:32 PM
gerritbot subscribed.Dec 9 2015, 3:03 PM

Change 257891 had a related patch set uploaded (by Hoo man):
Implement file modified time cache invalidation for TemplateModule

https://gerrit.wikimedia.org/r/257891

gerritbot added a project: Patch-For-Review.Dec 9 2015, 3:03 PM
hoo moved this task from Done to Review on the Wikidata-Sprint-2015-12-01 board.Dec 9 2015, 3:05 PM
gerritbot added a comment.Dec 9 2015, 3:36 PM

Change 257895 had a related patch set uploaded (by JanZerebecki):
Implement cache invalidation for TemplateModule

https://gerrit.wikimedia.org/r/257895

gerritbot added a comment.Dec 9 2015, 3:44 PM

Change 257891 merged by jenkins-bot:
Implement cache invalidation for TemplateModule

https://gerrit.wikimedia.org/r/257891

gerritbot added a comment.Dec 9 2015, 3:47 PM

Change 257895 merged by jenkins-bot:
Implement cache invalidation for TemplateModule

https://gerrit.wikimedia.org/r/257895

JanZerebecki renamed this task from edit and add statment icons are not there to missing cache invalidation for TemplateModule.Dec 9 2015, 4:12 PM
JanZerebecki closed this task as Resolved.
JanZerebecki updated the task description. (Show Details)
JanZerebecki moved this task from Review to Done on the Wikidata-Sprint-2015-12-01 board.Dec 9 2015, 8:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits