Page MenuHomePhabricator

FlaggedRevs begins with short PHP tags
Closed, ResolvedPublic


Author: titoxd.wikimedia

FlaggedRevs patch

The FlaggedRevs extension in the repo (as of r22744) begins with short PHP tags, which makes it die on systems that have them disabled.

Patch attached (which also fixes a typo and adds two links in the logs)

Version: unspecified
Severity: enhancement




Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:50 PM
bzimport set Reference to bz10143.
bzimport added a subscriber: Unknown Object (MLST).

Tags expanded.

No [[ ]] tags needed for logs, the HTML link is injected for $1 when parsed.

Also, I'd rather not use "deprecate" as that suggest something that is still in use but no longer added to and will be removed someday. When you "unreview" pages, it goes into immediate affect.