Page MenuHomePhabricator

French space fix
Closed, DeclinedPublic

Assigned To
None
Authored By
bzimport
Jun 13 2007, 5:29 PM
Referenced Files
F4050: remove_french_typo.diff
Nov 21 2014, 9:50 PM
F4048: french_space_fix.diff
Nov 21 2014, 9:50 PM
F4049: french_typo_extension.diff
Nov 21 2014, 9:50 PM

Description

Author: mike

Description:
The no-break space added before french punctuation symbols like ";", "!" or ":" is wrong. It should be one fourth of an em wide (see the french page about punctuation : http://fr.wikipedia.org/wiki/Ponctuation#Signes_de_ponctuation_occidentaux ).

Since the HTML entity doesn't look well supported, I suggest we replace the actual "&nbsp;" with "<span style="font-size: 0.25em;">&nbsp;</span>".


Version: 1.11.x
Severity: minor

Details

Reference
bz10246

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:50 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz10246.
bzimport added a subscriber: Unknown Object (MLST).

mike wrote:

spaces in front of punctuation replaced with a no-break space surrounded with a span with a font size of 0.25em

Attached:

mike wrote:

Same fix as extension

If you'd rather move this behavior to an extension, here's the code.

Attached:

mike wrote:

Removes french typo

And here's the patch to remove the behavior from the core.

Attached:

This would be far too fragile, producing invalid output where text appears eg inside HTML attribute values.

Doesn't really seem worth the effort, given that normal-sized spaces are being used to begin with.