Page MenuHomePhabricator

Allows whitelists of IP addresses in ConfirmEdit
Closed, ResolvedPublic

Description

Author: andy753421

Description:
patch with 'patch -P0 < ConfirmEditWhitelistIP.patch' from /extensions/ConfirmEdit

This is a feature I found useful on a Wiki I run. In my case, to allow all edits from my school's subnet.

It works by specifying an array of regexes to match against IP addresses, if the address matches the edit is allowed.


Version: unspecified
Severity: enhancement

attachment ConfirmEditWhitelistIP.patch ignored as obsolete

Details

Reference
bz10424

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:48 PM
bzimport set Reference to bz10424.
bzimport added a subscriber: Unknown Object (MLST).

It seems a bit odd to me to use a regex for an IP list.
It would seem cleaner to use existing (hopefully ;) functions for CIDR IP ranges.

andy753421 wrote:

Alternate patch to use CIDR ranges instead of regexs

There's nothing in PHP, but there seems to be something buried in /includes/IP.php ;)

Attached:

Looks good -- works for individual IPs as well as ranges, nice!

Applied in r23758, with some tweaks to the doc comment.