Page MenuHomePhabricator

Set up additional filters for Echo tables
Closed, ResolvedPublic

Description

The tables are echo_event, echo_notification, echo_email_batch, echo_target_page, and echo_unread_wikis.

The information is not publicly accessible, but there should be an additional filter in place.

Event Timeline

Mattflaschen-WMF raised the priority of this task from to Needs Triage.
Mattflaschen-WMF updated the task description. (Show Details)
Mattflaschen-WMF added projects: SRE, DBA.
jcrespo triaged this task as High priority.
jcrespo added a project: Cloud-VPS.
jcrespo set Security to None.
jcrespo moved this task from Triage to Backlog on the DBA board.

Two separate jobs to do here:

  • Add echo tables to puppet:manifests/realm.pp
  • Delete existing hidden tables

Change 268060 had a related patch set uploaded (by Jcrespo):
Add echo tables to the list of private tables

https://gerrit.wikimedia.org/r/268060

Change 268060 merged by Jcrespo:
Add echo tables to the list of private tables

https://gerrit.wikimedia.org/r/268060

Filters are both puppetized and applied live on sanitarium/labs.

They have been tested to work succesfully.

Now I have to delete all echo tables from there.

Dropping is ongoing, it will take some time as I do not want to affect labs' replication lag.

These tables where deleted in db1069 and labsdb*:

@Mattflaschen This is done, please continue reporting any potential issue regarding privacy && labs, even if data was not really exposed at any time, like in this case.

We *really* appreciate feedback from the code owners about tables, as sometimes labs is not taken into account when creating new features or they are forgotten when extensions/features are removed.