Page MenuHomePhabricator
Create Task
Maniphest T126050

"Preview" screen assumes changes have been made, even when there were none (doesn't happen on "Edit" screen)
Open, LowestPublic
Actions

Description

How to reproduce:

  • click "edit"
  • do not change anything and click "show preview"
  • click on any link leading outside
  • observe the pop-up message: "Leaving this page may lose changes you made"

It should only show the pop-up when actual changes have been made.

Event Timeline

Yurivict created this task.Feb 5 2016, 7:37 PM
Yurivict raised the priority of this task from to Needs Triage.
Yurivict updated the task description. (Show Details)
Yurivict added a project: MediaWiki-General.
Yurivict subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 5 2016, 7:37 PM
Aklapper closed this task as Invalid.Feb 6 2016, 12:25 PM
Aklapper claimed this task.
Aklapper edited projects, added MediaWiki-Page-editing; removed MediaWiki-General.
Aklapper set Security to None.

That is a feature of your browser, not of MediaWiki. Closing as invalid.

Yurivict added a comment.Feb 6 2016, 7:21 PM

I don't think that the browser is to blame here, because the problem doesn't happen when one clicks out of the page edit screen. It only happens on the preview screen which is a variation of the edit screen.

Yurivict renamed this task from "Preview" screen always assumes that changes have been made, even when there were none to "Preview" screen always assumes that changes have been made, even when there were none (doesn't happen on "Edit" screen).Feb 6 2016, 7:22 PM
Aklapper renamed this task from "Preview" screen always assumes that changes have been made, even when there were none (doesn't happen on "Edit" screen) to "Preview" screen assumes changes have been made, even when there were none (doesn't happen on "Edit" screen).Feb 7 2016, 8:25 PM
Aklapper reopened this task as Open.
Aklapper removed Aklapper as the assignee of this task.
Aklapper triaged this task as Lowest priority.
TheDJ subscribed.Feb 28 2016, 8:43 PM

After leaving the edit page, the javascript of mw.confirmCloseWindow no longer knows what the original text was. It therefore assumes that there have always been changes.

To fix this, you need to introduce a new form field into the submission form; "changed" that is set to true by the JS, when submitting a form, so that this state can be carried across from the edit to the preview page.

Yurivict added a comment.Feb 28 2016, 9:04 PM

Either the "changed" field, or the hash of the original text.

MGChecker moved this task from Backlog to Preview on the MediaWiki-Page-editing board.Nov 15 2018, 10:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL