Page MenuHomePhabricator

Button which is the same size as the player it covers is bad for some use cases. Player button causes linebreaks.
Closed, DeclinedPublic


Author: gmaxwell

There are many use cases on English Wikipedia where an audio playback link is desired in the middle of a paragraph. For example, see the pronunciation link at the top of . Most uses of are of this type.

In these cases the use of a block element around the player activation link is not acceptable and the minimum usable size of the player is too great.

I think the ideal behavior would be to add a keyword to the image tag to make the player appear as a small "PLAY" icon like the speaker icon currently added via CSS. launcheronly perhaps? :) When the icon is clicked it should insert the player at reasonable size (perhaps the size provided in the image tag) ideally as an inline element rather than a block element to avoid messing up layout.

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:54 PM
bzimport set Reference to bz11250.
bzimport added a subscriber: Unknown Object (MLST).

The use of a block-level element for the player was chosen with a great deal of consideration. It won't be changing any time soon, as far as I am concerned.

gmaxwell wrote:

Thats nice. However, the current behavior represents a regression from what we had previously: Before we had the ability to produce an inline play link that popped up a player. This was great for things like pronunciations. We don't have that anymore. I honestly don't care if it's an inline element, a block element, or a chemical element... The functionality is what matters.

Would you be morally opposed to having a mode where an inline play icon activates the player in a small floated div?

Submit a patch and I'll tell you what I think.

The OggHandler extension is not under active development anymore. It is unlikely that there will be any further active development.

OggHandler has been superseded by TimedMediaHandler:

Please use TimedMediaHandler instead.

Closing this report as WONTFIX as part of Bugzilla Housekeeping.

Please feel free to reopen this bug report in the future if either anyone takes the responsibility for active development of OggHandler again; or move this bug report from the "OggHandler" to the "TimedMediaHandler" component in Bugzilla if the same problem still happens when using TimedMediaHandler. Thanks.