Page MenuHomePhabricator
Create Task
Maniphest T132625

Resolve static analysis errors found by etsy/phan
Closed, ResolvedPublic
Actions

Description

Upgrading the elasticsearch plugins has been relatively easy because the compiler is able to tell us about changed/missing methods/classes/etc. The phan project can give us similar information about php. Resolve all, or as many as possible, errors than phan identifies in CirrusSearch so we can use it with the upgraded Elastica library to identify other possible issues.

Details

SubjectRepoBranchLines +/-
Fix missing variable in RescoreBuildermediawiki/extensions/CirrusSearchmaster+2 -0
Apply more annotations/type signature updatesmediawiki/extensions/CirrusSearchmaster+59 -24
More PhpDoc cleanupsmediawiki/extensions/CirrusSearchmaster+58 -21
Replace deprecated ConfigFactory::getDefaultInstance()mediawiki/extensions/CirrusSearches2.x+57 -30
Add annotations to Api, Elastica, and Extra sub-namespacesmediawiki/extensions/CirrusSearchmaster+113 -97
Add script to run etsy/phan from in vagrantmediawiki/extensions/CirrusSearchmaster+107 -0
Add @suppress annotations for unfixable static analysismediawiki/extensions/CirrusSearchmaster+67 -5
Add/update a variety of annotations to be correctmediawiki/extensions/CirrusSearchmaster+67 -27
Standardize namespace/use syntax and spacingmediawiki/extensions/CirrusSearchmaster+23 -15
Remove unused variablesmediawiki/extensions/CirrusSearchmaster+6 -30
Add more type annotations to CirrusSearch\BuildDocument namespacemediawiki/extensions/CirrusSearchmaster+102 -44
Standardize on catching/passing Elasticas ExceptionInterfacemediawiki/extensions/CirrusSearchmaster+7 -7
Add some missing @return annotationsmediawiki/extensions/CirrusSearchmaster+4 -2
Remove some unused `use` statementsmediawiki/extensions/CirrusSearchmaster+4 -9
Fix a few minor analysis issues in test casesmediawiki/extensions/CirrusSearchmaster+15 -3
Use the correct $exception variable instead of $emediawiki/extensions/CirrusSearchmaster+2 -2
Remove unused methodmediawiki/extensions/CirrusSearchmaster+0 -20
Spelling correctionsmediawiki/extensions/CirrusSearchmaster+104 -104
Drop unused method indexToIndexTypesmediawiki/extensions/CirrusSearchmaster+0 -38
Add missing properties and methods to maint classesmediawiki/extensions/CirrusSearchmaster+84 -21
Only call getData() if the right type of Action is usedmediawiki/extensions/CirrusSearchmaster+5 -1
Add more type annotations to CirrusSearch\Search namespacemediawiki/extensions/CirrusSearchmaster+254 -52
Annotate SearchResult and related classesmediawiki/extensions/CirrusSearchmaster+157 -34
Expand annotations in Elasticsearch\Maintenance namespacemediawiki/extensions/CirrusSearchmaster+163 -43
Make sure the Config instance really has a getElement methodmediawiki/extensions/CirrusSearchmaster+9 -3
search: getInterwikiResults returns array of SearchResultSetsmediawiki/coremaster+1 -1
Very minor cleanups to CirrusSearch\Job namespacemediawiki/extensions/CirrusSearchmaster+21 -7
Trivial whitespace changes to Elastica\LanguageDetectormediawiki/extensions/CirrusSearchmaster+8 -0
Make static analysis happy by forcing to stringmediawiki/extensions/CirrusSearchmaster+1 -1
Implement missing setMaxNgramsExtracted methodmediawiki/extensions/CirrusSearchmaster+11 -2
Cleanup annotations and signatures in CirrusSearch\LanguageDetectmediawiki/extensions/CirrusSearchmaster+16 -8
Cleanup annotations and signatures in CirrusSearch\BuildDocumentmediawiki/extensions/CirrusSearchmaster+44 -23
Cleanup annotations/signatures in CirrusSearch\\Sanitymediawiki/extensions/CirrusSearchmaster+65 -24
Minor static analysis cleanupsmediawiki/extensions/CirrusSearchmaster+18 -12
Replace deprecated ConfigFactory::getDefaultInstance()mediawiki/extensions/CirrusSearchmaster+57 -30
Show related patches Customize query in gerrit

Event Timeline

EBernhardson created this task.Apr 13 2016, 8:23 PM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptApr 13 2016, 8:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
EBernhardson moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.Apr 13 2016, 8:23 PM
gerritbot subscribed.Apr 13 2016, 11:02 PM

Change 283350 had a related patch set uploaded (by EBernhardson):
Replace deprecated ConfigFactory::getDefaultInstance()

https://gerrit.wikimedia.org/r/283350

gerritbot added a project: Patch-For-Review.Apr 13 2016, 11:02 PM
gerritbot added a comment.Apr 13 2016, 11:10 PM

Change 283353 had a related patch set uploaded (by EBernhardson):
Cleanup annotations/signatures in CirrusSearch\\Sanity

https://gerrit.wikimedia.org/r/283353

gerritbot added a comment.Apr 13 2016, 11:10 PM

Change 283352 had a related patch set uploaded (by EBernhardson):
Minor static analysis cleanups

https://gerrit.wikimedia.org/r/283352

gerritbot added a comment.Apr 13 2016, 11:11 PM

Change 283354 had a related patch set uploaded (by EBernhardson):
Cleanup annotations and signatures in CirrusSearch\BuildDocument

https://gerrit.wikimedia.org/r/283354

gerritbot added a comment.Apr 13 2016, 11:12 PM

Change 283355 had a related patch set uploaded (by EBernhardson):
Cleanup annotations and signatures in CirrusSearch\LanguageDetect

https://gerrit.wikimedia.org/r/283355

gerritbot added a comment.Apr 13 2016, 11:14 PM

Change 283356 had a related patch set uploaded (by EBernhardson):
Remove call to nonexistent method

https://gerrit.wikimedia.org/r/283356

gerritbot added a comment.Apr 13 2016, 11:14 PM

Change 283357 had a related patch set uploaded (by EBernhardson):
Make static analysis happy by forcing to string

https://gerrit.wikimedia.org/r/283357

gerritbot added a comment.Apr 13 2016, 11:14 PM

Change 283358 had a related patch set uploaded (by EBernhardson):
Add missing properties and methods to updateSuggesterIndex

https://gerrit.wikimedia.org/r/283358

gerritbot added a comment.Apr 14 2016, 4:05 PM

Change 283465 had a related patch set uploaded (by EBernhardson):
search: getInterwikiResults returns array of SearchResultSets

https://gerrit.wikimedia.org/r/283465

gerritbot added a comment.Apr 14 2016, 8:15 PM

Change 283350 merged by jenkins-bot:
Replace deprecated ConfigFactory::getDefaultInstance()

https://gerrit.wikimedia.org/r/283350

gerritbot added a comment.Apr 14 2016, 9:12 PM

Change 283556 had a related patch set uploaded (by EBernhardson):
Add/update a variety of annotations to be correct

https://gerrit.wikimedia.org/r/283556

gerritbot added a comment.Apr 14 2016, 9:12 PM

Change 283557 had a related patch set uploaded (by EBernhardson):
Standardize on catching/passing Elasticas ExceptionInterface

https://gerrit.wikimedia.org/r/283557

gerritbot added a comment.Apr 14 2016, 9:12 PM

Change 283558 had a related patch set uploaded (by EBernhardson):
Annotate SearchResult and related classes

https://gerrit.wikimedia.org/r/283558

gerritbot added a comment.Apr 14 2016, 9:12 PM

Change 283559 had a related patch set uploaded (by EBernhardson):
Fix missing variable in RescoreBuilder

https://gerrit.wikimedia.org/r/283559

gerritbot added a comment.Apr 14 2016, 9:12 PM

Change 283560 had a related patch set uploaded (by EBernhardson):
Add script to run etsy/phan from in vagrant

https://gerrit.wikimedia.org/r/283560

gerritbot added a comment.Apr 14 2016, 9:12 PM

Change 283561 had a related patch set uploaded (by EBernhardson):
Only call getData() if the right type of Action is used

https://gerrit.wikimedia.org/r/283561

gerritbot added a comment.Apr 14 2016, 9:12 PM

Change 283562 had a related patch set uploaded (by EBernhardson):
Make sure the Config instance really has a getElement method

https://gerrit.wikimedia.org/r/283562

gerritbot added a comment.Apr 14 2016, 10:32 PM

Change 283352 merged by jenkins-bot:
Minor static analysis cleanups

https://gerrit.wikimedia.org/r/283352

gerritbot added a comment.Apr 14 2016, 10:35 PM

Change 283353 merged by jenkins-bot:
Cleanup annotations/signatures in CirrusSearch\\Sanity

https://gerrit.wikimedia.org/r/283353

gerritbot added a comment.Apr 14 2016, 10:57 PM

Change 283578 had a related patch set uploaded (by EBernhardson):
Add more type annotations to CirrusSearch\Search namespace

https://gerrit.wikimedia.org/r/283578

gerritbot added a comment.Apr 14 2016, 10:57 PM

Change 283579 had a related patch set uploaded (by EBernhardson):
Add more type annotations to CirrusSearch\BuildDocument namespace

https://gerrit.wikimedia.org/r/283579

gerritbot added a comment.Apr 14 2016, 10:57 PM

Change 283580 had a related patch set uploaded (by EBernhardson):
Add annotations to Api, Elastica, and Extra sub-namespaces

https://gerrit.wikimedia.org/r/283580

gerritbot added a comment.Apr 14 2016, 10:57 PM

Change 283581 had a related patch set uploaded (by EBernhardson):
Very minor cleanups to CirrusSearch\Job namespace

https://gerrit.wikimedia.org/r/283581

gerritbot added a comment.Apr 14 2016, 10:57 PM

Change 283582 had a related patch set uploaded (by EBernhardson):
Trivial whitespace changes to Elastica\LanguageDetector

https://gerrit.wikimedia.org/r/283582

gerritbot added a comment.Apr 14 2016, 10:57 PM

Change 283583 had a related patch set uploaded (by EBernhardson):
Expand annotations in Elasticsearch\Maintenance namespace

https://gerrit.wikimedia.org/r/283583

gerritbot added a comment.Apr 14 2016, 11:47 PM

Change 283354 merged by jenkins-bot:
Cleanup annotations and signatures in CirrusSearch\BuildDocument

https://gerrit.wikimedia.org/r/283354

gerritbot added a comment.Apr 14 2016, 11:49 PM

Change 283355 merged by jenkins-bot:
Cleanup annotations and signatures in CirrusSearch\LanguageDetect

https://gerrit.wikimedia.org/r/283355

gerritbot added a comment.Apr 15 2016, 12:04 AM

Change 283356 merged by jenkins-bot:
Implement missing setMaxNgramsExtracted method

https://gerrit.wikimedia.org/r/283356

gerritbot added a comment.Apr 15 2016, 7:49 AM

Change 283357 merged by jenkins-bot:
Make static analysis happy by forcing to string

https://gerrit.wikimedia.org/r/283357

gerritbot added a comment.Apr 15 2016, 12:22 PM

Change 283582 merged by jenkins-bot:
Trivial whitespace changes to Elastica\LanguageDetector

https://gerrit.wikimedia.org/r/283582

gerritbot added a comment.Apr 16 2016, 10:39 PM

Change 283581 merged by jenkins-bot:
Very minor cleanups to CirrusSearch\Job namespace

https://gerrit.wikimedia.org/r/283581

gerritbot added a comment.Apr 18 2016, 7:42 AM

Change 283465 merged by jenkins-bot:
search: getInterwikiResults returns array of SearchResultSets

https://gerrit.wikimedia.org/r/283465

gerritbot added a comment.Apr 18 2016, 9:12 PM

Change 283562 merged by jenkins-bot:
Make sure the Config instance really has a getElement method

https://gerrit.wikimedia.org/r/283562

gerritbot added a comment.Apr 19 2016, 12:14 AM

Change 283583 merged by jenkins-bot:
Expand annotations in Elasticsearch\Maintenance namespace

https://gerrit.wikimedia.org/r/283583

gerritbot added a comment.Apr 19 2016, 12:18 AM

Change 283558 merged by jenkins-bot:
Annotate SearchResult and related classes

https://gerrit.wikimedia.org/r/283558

gerritbot added a comment.Apr 19 2016, 12:47 AM

Change 283578 merged by jenkins-bot:
Add more type annotations to CirrusSearch\Search namespace

https://gerrit.wikimedia.org/r/283578

gerritbot added a comment.Apr 19 2016, 1:28 AM

Change 283561 merged by jenkins-bot:
Only call getData() if the right type of Action is used

https://gerrit.wikimedia.org/r/283561

gerritbot added a comment.Apr 19 2016, 5:02 AM

Change 283358 merged by jenkins-bot:
Add missing properties and methods to maint classes

https://gerrit.wikimedia.org/r/283358

gerritbot added a comment.Apr 19 2016, 8:02 PM

Change 284260 had a related patch set uploaded (by EBernhardson):
Apply more annotations/type signature updates

https://gerrit.wikimedia.org/r/284260

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 8:02 PM
gerritbot added a comment.Apr 19 2016, 8:05 PM

Change 284238 had a related patch set uploaded (by EBernhardson):
More PhpDoc cleanups

https://gerrit.wikimedia.org/r/284238

gerritbot added a comment.Apr 19 2016, 8:11 PM

Change 284261 had a related patch set uploaded (by EBernhardson):
Drop unused method indexToIndexTypes

https://gerrit.wikimedia.org/r/284261

gerritbot added a comment.Apr 19 2016, 8:11 PM

Change 284216 had a related patch set uploaded (by EBernhardson):
Fix a few minor analysis issues in test cases

https://gerrit.wikimedia.org/r/284216

gerritbot added a comment.Apr 19 2016, 8:11 PM

Change 284211 had a related patch set uploaded (by EBernhardson):
Remove unused method

https://gerrit.wikimedia.org/r/284211

gerritbot added a comment.Apr 19 2016, 8:11 PM

Change 284208 had a related patch set uploaded (by EBernhardson):
Add some missing @return annotations

https://gerrit.wikimedia.org/r/284208

gerritbot added a comment.Apr 19 2016, 8:11 PM

Change 284209 had a related patch set uploaded (by EBernhardson):
Remove some unused use statements

https://gerrit.wikimedia.org/r/284209

gerritbot added a comment.Apr 19 2016, 8:11 PM

Change 284210 had a related patch set uploaded (by EBernhardson):
Remove unused variables

https://gerrit.wikimedia.org/r/284210

gerritbot added a comment.Apr 19 2016, 8:12 PM

Change 284212 had a related patch set uploaded (by EBernhardson):
Cleanup some potentially undefined variables

https://gerrit.wikimedia.org/r/284212

gerritbot added a comment.Apr 19 2016, 8:12 PM

Change 283563 had a related patch set uploaded (by EBernhardson):
Add @suppress annotations for unfixable static analysis

https://gerrit.wikimedia.org/r/283563

gerritbot added a comment.Apr 19 2016, 8:43 PM

Change 284345 had a related patch set uploaded (by EBernhardson):
Spelling corrections

https://gerrit.wikimedia.org/r/284345

gerritbot added a comment.Apr 19 2016, 9:38 PM

Change 284362 had a related patch set uploaded (by EBernhardson):
Standardize namespace/use syntax and spacing

https://gerrit.wikimedia.org/r/284362

gerritbot added a comment.Apr 19 2016, 9:41 PM

Change 284261 merged by jenkins-bot:
Drop unused method indexToIndexTypes

https://gerrit.wikimedia.org/r/284261

gerritbot added a comment.Apr 19 2016, 10:00 PM

Change 284345 merged by jenkins-bot:
Spelling corrections

https://gerrit.wikimedia.org/r/284345

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)).Apr 19 2016, 11:02 PM
gerritbot added a comment.Apr 19 2016, 11:09 PM

Change 284211 merged by jenkins-bot:
Remove unused method

https://gerrit.wikimedia.org/r/284211

• Deskana triaged this task as Medium priority.Apr 19 2016, 11:53 PM
• Deskana removed a project: Discovery-Search.
gerritbot added a comment.Apr 20 2016, 12:02 AM

Change 284212 merged by jenkins-bot:
Use the correct $exception variable instead of $e

https://gerrit.wikimedia.org/r/284212

ReleaseTaggerBot added a project: MW-1.27-release-notes.Apr 20 2016, 12:02 AM
gerritbot added a comment.Apr 20 2016, 12:07 AM

Change 284216 merged by jenkins-bot:
Fix a few minor analysis issues in test cases

https://gerrit.wikimedia.org/r/284216

gerritbot added a comment.Apr 20 2016, 12:13 AM

Change 284209 merged by jenkins-bot:
Remove some unused use statements

https://gerrit.wikimedia.org/r/284209

gerritbot added a comment.Apr 20 2016, 12:13 AM

Change 284208 merged by jenkins-bot:
Add some missing @return annotations

https://gerrit.wikimedia.org/r/284208

gerritbot added a comment.Apr 20 2016, 12:17 AM

Change 283557 merged by jenkins-bot:
Standardize on catching/passing Elasticas ExceptionInterface

https://gerrit.wikimedia.org/r/283557

gerritbot added a comment.Apr 20 2016, 1:12 AM

Change 283579 merged by jenkins-bot:
Add more type annotations to CirrusSearch\BuildDocument namespace

https://gerrit.wikimedia.org/r/283579

gerritbot added a comment.Apr 20 2016, 3:27 AM

Change 284210 merged by jenkins-bot:
Remove unused variables

https://gerrit.wikimedia.org/r/284210

gerritbot added a comment.Apr 20 2016, 6:39 AM

Change 284362 merged by jenkins-bot:
Standardize namespace/use syntax and spacing

https://gerrit.wikimedia.org/r/284362

gerritbot added a comment.Apr 20 2016, 7:24 AM

Change 283556 merged by jenkins-bot:
Add/update a variety of annotations to be correct

https://gerrit.wikimedia.org/r/283556

gerritbot added a comment.Apr 20 2016, 6:02 PM

Change 283563 merged by jenkins-bot:
Add @suppress annotations for unfixable static analysis

https://gerrit.wikimedia.org/r/283563

gerritbot added a comment.Apr 21 2016, 6:03 PM

Change 283560 merged by jenkins-bot:
Add script to run etsy/phan from in vagrant

https://gerrit.wikimedia.org/r/283560

gerritbot added a comment.Apr 21 2016, 10:26 PM

Change 283580 merged by jenkins-bot:
Add annotations to Api, Elastica, and Extra sub-namespaces

https://gerrit.wikimedia.org/r/283580

gerritbot added a comment.Apr 21 2016, 11:48 PM

Change 284837 had a related patch set uploaded (by EBernhardson):
Replace deprecated ConfigFactory::getDefaultInstance()

https://gerrit.wikimedia.org/r/284837

gerritbot added a comment.Apr 21 2016, 11:48 PM

Change 284837 abandoned by EBernhardson:
Replace deprecated ConfigFactory::getDefaultInstance()

https://gerrit.wikimedia.org/r/284837

gerritbot added a comment.Apr 22 2016, 12:09 AM

Change 284238 merged by jenkins-bot:
More PhpDoc cleanups

https://gerrit.wikimedia.org/r/284238

gerritbot added a comment.Apr 22 2016, 12:13 AM

Change 284260 merged by jenkins-bot:
Apply more annotations/type signature updates

https://gerrit.wikimedia.org/r/284260

gerritbot added a comment.Apr 25 2016, 2:40 PM

Change 283559 merged by jenkins-bot:
Fix missing variable in RescoreBuilder

https://gerrit.wikimedia.org/r/283559

EBernhardson moved this task from not in use - please delete to Needs Reporting on the Discovery-Search (Current work) board.Apr 26 2016, 6:56 PM
• Deskana closed this task as Resolved.Apr 26 2016, 10:14 PM
• Deskana subscribed.

I'll take your word for it. ;-)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits