Page MenuHomePhabricator

Superfluous parameter in method calls in LoadBalancer.php
Closed, ResolvedPublic

Description

Author: kelly.lynn.martin

Description:
In LoadBalancer.php (r23531), the method calls to getGroupIndex at lines 327 and 333 include $i as a superfluous second parameter. This is basically harmless, but perhaps confusing.


Version: 1.12.x
Severity: trivial

Details

Reference
bz11453

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:00 PM
bzimport set Reference to bz11453.
bzimport added a subscriber: Unknown Object (MLST).

No second parameter appears to have ever existed on the function, so taking it off in r26168.