Page MenuHomePhabricator

Superfluous parameter in method call in Math.php
Closed, ResolvedPublic

Description

Author: kelly.lynn.martin

Description:
Math.php, r24065, line 166, call to Database::replace has an extra argument "array('IGNORE')". Probably added by someone who mistakenly thought replace takes the same arguments as insert. Replace does not accept an options argument in Database or any of its subclassed implementations, so it would be wise to check the code in MathRenderer to ensure that it is not relying on behavior which the Database class does not offer. If the "IGNORE" behavior of insert is important to MathRenderer's use of replace here, then the Database class need to provide it.


Version: 1.12.x
Severity: minor

Details

Reference
bz11475

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:54 PM
bzimport set Reference to bz11475.
bzimport added a subscriber: Unknown Object (MLST).