Maniphest T13507

Small bug in new sffLinkText
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Sep 30 2007, 1:04 AM

Tags

Referenced Files

None

Subscribers

None

Description

Author: lgerbarg

Description:
One line fixup.

There is a small error the new sffLinkText you included. The last line is "return $l->makeLinkObj($title, $label);" but $label is undefined. I think it should be "return $l->makeLinkObj($title, $text);"

Patch attached.

Version: unspecified
Severity: enhancement

Attached:

SF4.diff408 BDownload

Details

Reference: bz11507

Revisions and Commits

rARC Arcanist
	rARC68f050bd14e0 Allow HTTPFuture callers to disable processing of "Content-Encoding" response…
	rARC377ed2ed8db7 If the Conduit server asserts it has the "gzip" capability, compress requests
	rARCa77da426af20 If the Conduit client supports gzip, make calls with "Accept-Encoding: gzip"
	rARC890b57de1e34 In "phutil_loggable_string()", encode every byte above 0x7F
	rARC7e25288f4968 Compress requests from the Conduit client to Phabricator

Related Objects

Mentioned In: rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator"

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:56 PM

• bzimport added a project: MediaWiki-extensions-Page_Forms.

• bzimport set Reference to bz11507.

• bzimport created this task.Sep 30 2007, 1:04 AM

Code changed in version 0.6.5; thanks for the fix.

epriestley added a commit: rARC7e25288f4968: Compress requests from the Conduit client to Phabricator.Aug 13 2020, 9:37 PM

epriestley mentioned this in rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator".

epriestley added a commit: rARC890b57de1e34: In "phutil_loggable_string()", encode every byte above 0x7F.

epriestley added a commit: rARCa77da426af20: If the Conduit client supports gzip, make calls with "Accept-Encoding: gzip".

epriestley added a commit: rARC377ed2ed8db7: If the Conduit server asserts it has the "gzip" capability, compress requests.

epriestley added a commit: rARC68f050bd14e0: Allow HTTPFuture callers to disable processing of "Content-Encoding" response….