Page MenuHomePhabricator

parseQuery method missing from SearchMySQL
Closed, ResolvedPublic


Author: kelly.lynn.martin

The SearchMySQL method (includes/SearchMySQL.php, r23531) is missing the parseQuery method. This is likely to cause all sorts of bad things to happen if you try to run MediaWiki with $wgSearchType set to "SearchMySQL". Most people will, of course, use SearchMySQL4 instead, and MediaWiki has required MySQL 4 since (I believe) 1.7.

Fix: Eliminate the class & module (by folding all nonoverridden methods in SearchMySQL4), or alias it to SearchMySQL4, or rig the class so that MediaWiki will throw a meaningful error in the event that someone tries to start up MediaWiki with SearchMySQL as the selected search engine.

Version: 1.12.x
Severity: minor



Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:00 PM
bzimport set Reference to bz11563.
bzimport added a subscriber: Unknown Object (MLST).

Since SearchMySQL3 was obsoleted out, the simplest thing would be to just merge SearchMySQL4 entirely into the SearchMySQL class, and just keep SearchMySQL4 as an alias (child class with no changes).