Page MenuHomePhabricator

Refactor the default cassandra monitoring into a separate class
Closed, ResolvedPublic

Description

Hi Services team!

While reviewing AQS alarms I noticed that Analytics created some CQL probes and the cassandra::instance module was already providing some. All the context is in https://gerrit.wikimedia.org/r/#/c/292568

After a long discussion it would be great to spend a bit of time thinking if a specific cassandra::monitoring class would give use more flexibility. A role could include cassandra::instance and decide to use the cassandra::monitoring class (configuring it with specific parameters like the nrpe_monitoring contact_group) or just to use a separate module.

Use case that generated the discussion: Analytics would like to add its nagios contact to the cassandra default one "admins,team_services" but there is no way to do it at the moment. Parametrizing the contact_group would be an option but what if somebody else comes up with a similar use case? A completely configurable cassandra::monitoring class would probably be more flexible in the longer term.

Event Timeline

Change 293916 had a related patch set uploaded (by JanZerebecki):
Add a notification parameter of analytics to cassandra monitoring

https://gerrit.wikimedia.org/r/293916

Change 293916 abandoned by JanZerebecki:
Add a notification parameter of analytics to cassandra monitoring

https://gerrit.wikimedia.org/r/293916

Change 295123 had a related patch set uploaded (by Nicko):
T137422 Refactor the default cassandra monitoring into a separate class

https://gerrit.wikimedia.org/r/295123

Change 295125 had a related patch set uploaded (by Nicko):
T137422 Include cassandra monitoring in all the ::cassandra calls

https://gerrit.wikimedia.org/r/295125

Change 295125 abandoned by Nicko:
T137422 Include cassandra monitoring in all the ::cassandra calls

Reason:
I will do another one as I got a little lost with gerrit and the dependent changes intricated and so on

https://gerrit.wikimedia.org/r/295125

Change 295125 restored by Nicko:
T137422 Include cassandra monitoring in all the ::cassandra calls

Reason:
trying something else sorry

https://gerrit.wikimedia.org/r/295125

Eevans triaged this task as Medium priority.Jul 6 2016, 3:32 PM
elukey claimed this task.
elukey added a subscriber: Nicko.

Changes deployed successfully, thanks a lot @Nicko for all the work!