TMH video.js-mode 'info' button link normalization
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• brooke
	Jun 27 2016, 4:24 PM

Description

Followup from https://gerrit.wikimedia.org/r/#/c/288122/ -- 'info' button resulting link doesn't quite match standard MW title->url escaping. Needs also to escape the Unicode bits in the file namespace.

Maybe best to use mw.title ?

Details

	Subject	Repo	Branch	Lines +/-
	Encode namespace when generating info link	mediawiki/extensions/TimedMediaHandler	master	+7 -5
	Encode namespace when generating info link	mediawiki/extensions/TimedMediaHandler	master	+3 -4

Customize query in gerrit

Event Timeline

• brooke created this task.Jun 27 2016, 4:24 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 27 2016, 4:24 PM

TheDJ moved this task from Backlog to Video.js on the Kaltura player board.Oct 18 2016, 6:52 PM

Change 316938 had a related patch set uploaded (by TheDJ):
Untested: Encode namespace when generating info link

https://gerrit.wikimedia.org/r/316938

gerritbot added a project: Patch-For-Review.Oct 20 2016, 8:42 AM

TheDJ claimed this task.Oct 20 2016, 8:43 AM

TheDJ added a project: TimedMediaHandler.

TheDJ moved this task from To sort to Doing on the TimedMediaHandler board.

Change 316938 abandoned by TheDJ:
Encode namespace when generating info link

https://gerrit.wikimedia.org/r/316938

TheDJ removed TheDJ as the assignee of this task.Sep 18 2017, 1:40 PM

TheDJ subscribed.

Change 493308 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Encode namespace when generating info link

https://gerrit.wikimedia.org/r/493308

• brooke claimed this task.Feb 27 2019, 8:16 PM

Change 493308 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Encode namespace when generating info link

https://gerrit.wikimedia.org/r/493308

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 5 2019, 6:00 PM

TheDJ closed this task as Resolved.May 8 2019, 11:22 AM

TheDJ removed a project: Patch-For-Review.

TheDJ moved this task from Doing to Done on the TimedMediaHandler board.

Aklapper removed a project: TimedMediaHandler.Nov 7 2019, 4:02 PM