Page MenuHomePhabricator
Create Task
Maniphest T139235

"Sudo" extension / Fatal error: Call to a member function params()
Closed, ResolvedPublic
Actions

Description

Setup

  • MediaWiki - 1.27.0 (758cd9d)
  • PHP - 5.6.22-0+deb8u1 (apache2handler)
  • MariaDB - 10.0.26-MariaDB-1~jessie
  • Sudo - 0.4.0 (b330ba9)

Issue
When trying to return from the sudoed account to the sudoer's account the following fatal occurs:

Fatal error: Call to a member function params() on string in /.../w/extensions/Sudo/SpecialSudo.php on line 131

I am not sure which branch started to have this issue. Perhaps it is connected the the new auth management in MediaWiki though I am just speculating here.

Details

SubjectRepoBranchLines +/-
Add missing ) on line 131mediawiki/extensions/Sudomaster+2 -3
Add missing ) on line 131mediawiki/extensions/SudoREL1_27+2 -3
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Jul 2 2016, 1:41 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 2 2016, 1:41 PM
Kghbln added a subscriber: DanielFriesen.Jul 2 2016, 1:42 PM

@DanielFriesen You will probably like to have a peep at this. Help and a fix will be appreciated.

Kghbln added a project: MediaWiki-extensions-General.Jul 2 2016, 1:51 PM
gerritbot subscribed.Jul 2 2016, 2:35 PM

Change 297128 had a related patch set uploaded (by Paladox):
Add missing ) on line 131

https://gerrit.wikimedia.org/r/297128

gerritbot added a project: Patch-For-Review.Jul 2 2016, 2:35 PM
Paladox subscribed.Jul 2 2016, 2:39 PM
Kghbln added a comment.Jul 2 2016, 2:46 PM

Quote self:

I am not sure which branch started to have this issue.

So this issue is only on REL1_27 and master. A backport to REL1_27 should be authored too.

@Paladox Great! Thanks!

Paladox added a comment.Jul 2 2016, 2:48 PM

@Kghbln hi, does the patch work, since I'm unsure if I did it correctly.

Could you test please.

Kghbln added a comment.Jul 2 2016, 2:53 PM

@Paladox Affirmative, the fix works as a field test proves!

Paladox added a comment.Jul 2 2016, 2:54 PM

@Kghbln thanks, and thanks for testing.

gerritbot added a comment.Jul 2 2016, 3:01 PM

Change 297130 had a related patch set uploaded (by Paladox):
Add missing ) on line 131

https://gerrit.wikimedia.org/r/297130

gerritbot added a comment.Jul 3 2016, 12:02 PM

Change 297128 merged by jenkins-bot:
Add missing ) on line 131

https://gerrit.wikimedia.org/r/297128

gerritbot added a comment.Jul 3 2016, 12:03 PM

Change 297130 merged by jenkins-bot:
Add missing ) on line 131

https://gerrit.wikimedia.org/r/297130

Paladox closed this task as Resolved.Jul 3 2016, 1:40 PM
Paladox claimed this task.
Paladox removed a project: Patch-For-Review.
Paladox removed a subscriber: gerritbot.

Closing as resolved, please reopen if the problem still happens.

Kghbln awarded a token.Jul 3 2016, 2:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL