FileSearchIndexer.php code review
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Dec 10 2007, 6:50 PM

Description

Author: alno

Description:
typos and variable name corrections

Bugs found while reviewing MediaWiki extensions code in Eclipse 3.3

Version: unspecified
Severity: trivial

Attached:

patch_FileSearchIndexer.txt691 BDownload

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:59 PM

• bzimport set Reference to bz12269.

• bzimport added a subscriber: Unknown Object (MLST).

The code appears quite correct as it is; patch would break it.

getExtractor() instantiates the appropriate class for a given MIME type and returns the object, or null if no class is registered for that type.

Patch would return the class name instead of a new instance of the class, causing the code to fail.