Page MenuHomePhabricator

Proofreadpage Index form shows unwanted fields on Norwegian Wikisource
Closed, DeclinedPublic

Description

From https://wikisource.org/wiki/Wikisource:Scriptorium#Proofreadpage_on_the_Norwegian_Wikisource

Index page form shows unwanted fields.

"MediaWiki:Proofreadpage index attributes" and "MediaWiki:Proofreadpage js attributes" were deleted 2 days ago, but still captures data from them (e.g. "Merknader" field), even "MediaWiki:Proofreadpage index data config" exists and does not contain them.

If I understand the code, in getDataConfig function (ProofreadIndexPage.php), it looks up for 'proofreadpage_index_data_config'. (1) If it exists, then gets data; (2) if not, then uses 'proofreadpage_index_attributes' and ''proofreadpage_js_attributes''.
The code flow is going by the (2) condition, because the form in no.source has the the fields indicated in the deleted "proofreadpage_index_attributes". No error message is shown in a preview.
So, why it does not detect 'proofreadpage_index_data_config'? Does it have any relation to the use of "inContentLanguage" and bug T126146? Some DB refresh needed?

Thanks!

Event Timeline

It seems that the bugg is not specific to the Proofread extension:

It seems to me that our wiki is ignoring all pages in the MediaWiki namespace and using a default instead

(from Scriptorium)

Sorry this hasn't received any attention yet.
Specific steps to reproduce are welcome which allow someone else to click / follow the steps and see the same results.

All this happens only in https://no.wikisource.org.

I first write the easier example: it doesn't exist a link to "Project:Kontoret" in the sidebar, despite of it is added to MediaWiki:Sidebar. In the default MediaWiki:Sidebar there should not exist any "Project:Kontoret" and that could be the reason for which we can not see that link: it is being used the default one?

The original bugg was more complex to explain, but it seems that the cause could be the same:

Try to edit any Index namespace page. E.g. https://no.wikisource.org/w/index.php?title=Indeks:Nansen,Fridtjof-Fram_over_Polhavet_I-1942.djvu&action=edit

We can see a form with the following 8 fields: Forfatter, Tittel, Utgivelsesår, Utgiver, Kilde, Omslagsbilde, Sider and Merknader.

Those 8 fields come from https://no.wikisource.org/wiki/MediaWiki:Proofreadpage_index_attributes which is deleted.

As long as "MediaWiki:Proofreadpage index data config" exists, the form has to show the fields of "MediaWiki:Proofreadpage index data config", not the fields of "MediaWiki:Proofreadpage_index_attributes".

Perhaps the software is not detecting the existence of "MediaWiki:Proofreadpage index data config" and assumes the default "MediaWiki:Proofreadpage_index_attributes"?

Thanks!

Hi! It seems that this bugg has been solved in no.wikisource. Plese, it can be closed as solved (it would be interesting to know how it was fixed). Best regards! -~~~~

Thanks for the update! Closing as per last comment (feel free to do so yourself via "Add Action... > Change Status" to 'declined' (not reproducible).