Page MenuHomePhabricator
Create Task
Maniphest T143596

size() jQuery method is deprecated
Closed, ResolvedPublic
Actions

Description

In resources/src/jquery/jquery.makeCollapsible.js there is used (twice) size() method.

Accordingly to http://api.jquery.com/size/ this is deprecated as of jQuery 1.8. Should use length property instead.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Deprecated jQuery method .size() replaced with property .lengthVictorPortonmediawiki/coremaster+2 -2
Customize query in gerrit

Event Timeline

VictorPorton created this task.Aug 22 2016, 7:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2016, 7:22 PM
gerritbot subscribed.Aug 22 2016, 8:21 PM

Change 306051 had a related patch set uploaded (by VictorPorton):
Deprecated jQuery method .size() replaced with property .length

https://gerrit.wikimedia.org/r/306051

gerritbot added a project: Patch-For-Review.Aug 22 2016, 8:21 PM
• matmarex closed this task as Resolved.Aug 22 2016, 9:31 PM
• matmarex assigned this task to VictorPorton.
• matmarex added a project: MediaWiki-General.
• matmarex removed a project: Patch-For-Review.
• matmarex subscribed.

Thank you for the patch!

gerritbot added a comment.Aug 22 2016, 10:31 PM

Change 306051 merged by jenkins-bot:
Deprecated jQuery method .size() replaced with property .length

https://gerrit.wikimedia.org/r/306051

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)), MW-1.28-release-notes.Aug 22 2016, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits