Page MenuHomePhabricator

size() jQuery method is deprecated
Closed, ResolvedPublic

Description

In resources/src/jquery/jquery.makeCollapsible.js there is used (twice) size() method.

Accordingly to http://api.jquery.com/size/ this is deprecated as of jQuery 1.8. Should use length property instead.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2016, 7:22 PM

Change 306051 had a related patch set uploaded (by VictorPorton):
Deprecated jQuery method .size() replaced with property .length

https://gerrit.wikimedia.org/r/306051

matmarex closed this task as Resolved.Aug 22 2016, 9:31 PM
matmarex assigned this task to VictorPorton.
matmarex added a project: MediaWiki-General.
matmarex removed a project: Patch-For-Review.
matmarex added a subscriber: matmarex.

Thank you for the patch!

Change 306051 merged by jenkins-bot:
Deprecated jQuery method .size() replaced with property .length

https://gerrit.wikimedia.org/r/306051