Page MenuHomePhabricator
Create Task
Maniphest T144275

welcome.py L10N fails for commons
Closed, ResolvedPublic
Actions

Description

welcome.py uses i8n.translate() to get a string from dictionaries for a given site. This mechanism fails for commons due to the '_default' entry because translate() expects a language code here when no fallback is given.

Details

SubjectRepoBranchLines +/-
[bugfix] cleanup L10N dictionariespywikibot/coremaster+15 -26
Customize query in gerrit

Event Timeline

Xqt created this task.Aug 30 2016, 2:51 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptAug 30 2016, 2:51 PM
Xqt triaged this task as Medium priority.Aug 30 2016, 2:51 PM
gerritbot subscribed.Aug 30 2016, 3:07 PM

Change 307523 had a related patch set uploaded (by Xqt):
[bugfix] cleanup L10N dictionaries

https://gerrit.wikimedia.org/r/307523

gerritbot added a project: Patch-For-Review.Aug 30 2016, 3:07 PM
gerritbot added a comment.Sep 18 2016, 2:36 AM

Change 307523 merged by jenkins-bot:
[bugfix] cleanup L10N dictionaries

https://gerrit.wikimedia.org/r/307523

whym closed this task as Resolved.Sep 18 2016, 2:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits