Page MenuHomePhabricator

AddPage is not passing super_page along
Closed, ResolvedPublic

Description

Author: sergey.chernyshev

Description:
Add super_page as hidden form value

When AddPage is called with super_page parameter, it's not being added as hidden form value as target namespace does.

Patch attached.


Version: unspecified
Severity: enhancement

attachment super_page.patch ignored as obsolete

Details

Reference
bz12594

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:05 PM
bzimport set Reference to bz12594.

sergey.chernyshev wrote:

Same patch, but also fixes code insertion security vulnerability

This patch also fixes code insertion security vulnerability for namespace and super_page params.

attachment super_page.patch ignored as obsolete

sergey.chernyshev wrote:

Une more addition - we'll also pass 'params' parameter on

I also added passing 'params' parameter on for additional parameters (e.g. presetting form values) completing {{#forminput}} functionality as URL call to AddPage.

Attached:

I added this code in version 0.8.3; thanks.