Author: skizzerz
Description:
Patch for SpecialUserrights.php
The attached patch file patches SpecialUserrights.php to silently prevent the logging of rights changes if nothing is changed (such as the case in the link).
Version: 1.12.x
Severity: enhancement
URL: http://en.wikipedia.org/wiki/Wikipedia_talk:Requests_for_rollback#Rollback_rights_pile-on
Attached:
Can't this be done more cleanly? Like if(empty(array_diff($added, $removed)) && empty(array_diff($removed, $added)) ? (array_diff of course only lists elements present only in A and not in B, but not the other way around. Thanks, PHP!)
skizzerz wrote:
marking as FIXED after a conversion w/ Simetrical in IRC (and a test on my local install after I ran the svn update) showed that this was already fixed in r29526
matthew.britton wrote:
Reopening; despite r29526 having been live for a couple of days no-changes are still being logged. See for example http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=rights&page=User%3A+Deli+nk