Page MenuHomePhabricator

Textarea in ArticleFeedbackv5 card that says "Help improve this page" can be expanded further than it should; a max-width property should be added to the textarea element
Closed, ResolvedPublic

Description

When there's no max length (basically [max-width](https://developer.mozilla.org/en-US/docs/Web/CSS/max-width) CSS property), the textarea can be set to go past the container/card. See screenshot for information. It should be set with a % unit so it can be responsive.

pasted_file (738×1 px, 158 KB)

Event Timeline

SamanthaNguyen renamed this task from Add max-length property to textarea in ArticleFeedbackv5 card that says "Help improve this page" to Add max-width property to textarea in ArticleFeedbackv5 card that says "Help improve this page".Sep 24 2016, 5:09 PM
SamanthaNguyen renamed this task from Add max-width property to textarea in ArticleFeedbackv5 card that says "Help improve this page" to Textarea in ArticleFeedbackv5 card that says "Help improve this page" can be expanded further than it should; a max-width property should be added to the textarea element.Sep 24 2016, 5:11 PM
SamanthaNguyen moved this task from Feedback to Bugs on the ArticleFeedbackv5 board.

max-width: 100%; seems to fix this issue :)

Change 312738 had a related patch set uploaded (by Jack Phoenix):
Specify max-width for the feedback <textarea> to prevent overflowing

https://gerrit.wikimedia.org/r/312738

Change 312738 merged by jenkins-bot:
Specify max-width for the feedback <textarea> to prevent overflowing

https://gerrit.wikimedia.org/r/312738

SamanthaNguyen claimed this task.
SamanthaNguyen removed a project: Patch-For-Review.