Page MenuHomePhabricator

Remove "m." fallback from networking
Closed, ResolvedPublic

Description

I investigated the "m." fallback removal in this spike...
https://phabricator.wikimedia.org/T145397

... and confirmed with Android guys that only the "action=zeroconfig" request needs to go against "m."

So we should be good to go to...

  • Remove all "m." fallback logic.
  • Just make "action=zeroconfig" always go directly against "m."

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Some relevant bits:

  • WMFZeroConfigurationFetcher (change to just always go agains "m." - could maybe make this just use plain NSURLSession bits so more of the crufty networking code could go away sooner?)
  • wmf_isMobile and wmf_mobileAPIURLForURL can go away (this will have cascading effects elsewhere in the code which will mostly involve deleting no-longer-needed parameters)
  • wmf_domain and wmf_language (no more need to check for "m")
  • tests which depend on ".m." will need to be updated
  • Do extensive testing to ensure the Wikipedia Zero bits still work (I will probably have to do this in SF office as we have a testing wifi network which makes this easier)

etc...

JMinor triaged this task as Medium priority.Oct 3 2016, 5:40 PM

This could get pretty big/risky, so lets make sure to have a good understanding before we start work here.

From the product side, this is not a user priority, but seems like a worthwhile tech debt project, and is currently making analyzing our page request/view data more difficult. Setting as Normal for now.

Fjalapeno renamed this task from Remove "m." fallback from networking bits. to Remove "m." fallback from networking.Nov 1 2016, 3:18 PM
JoeWalsh claimed this task.