Author: fredrik.agert
Description:
in file ../includes/Math.php
Debugging my wiki I keep getting 'math_unknown_error' from the code line 113-118 even
though the $retval is set to 'E' meaning 'math_lexing_error'
switch block has no "break;"-statement
current code
<pre>
switch( $retval ) {
case 'E': $errmsg = $this->_error( 'math_lexing_error', $errbit );
case 'S': $errmsg = $this->_error( 'math_syntax_error', $errbit );
case 'F': $errmsg = $this->_error( 'math_unknown_function', $errbit );
default: $errmsg = $this->_error( 'math_unknown_error', $errbit );
}</pre>
suggested change
<pre>
switch( $retval ) {
case 'E': $errmsg = $this->_error( 'math_lexing_error', $errbit );
break;
case 'S': $errmsg = $this->_error( 'math_syntax_error', $errbit );
break;
case 'F': $errmsg = $this->_error( 'math_unknown_function', $errbit );
break;
default: $errmsg = $this->_error( 'math_unknown_error', $errbit );
}</pre>
Version: 1.11.x
Severity: trivial
OS: Linux
Platform: PC
URL: http://agert.homelinux.org/blog/index.php/Superheterodyn#Teknisk_funktion