Maniphest T149386

RTL layout broken on WMFFeedNotificationHeader button
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Oct 27 2016, 11:44 PM

Tags

Referenced Files

	F4678296: T149386.PNG
	Oct 30 2016, 11:04 PM

	F4671637: cd8e663a-9c65-11e6-8808-212a600464bc.png
	Oct 28 2016, 8:56 PM

	F4671635: d762d92a-9c65-11e6-8e4f-0923d85c9284.png
	Oct 28 2016, 8:56 PM

	F4668481: Screen Shot 2016-10-27 at 4.43.52 PM.png
	Oct 27 2016, 11:44 PM

Subscribers

Description

Screen Shot 2016-10-27 at 4.43.52 PM.png (1×974 px, 288 KB)

Related Objects

Mentioned In: rAPIOSa646e375802d: Merge branch 'bug/notification-header-rtl-button/T149386' of github.com…
rAPIOSeb4679a0bead: Merge pull request #998 from wikimedia/bug/notification-header-rtl…
rAPIOS8691112163e8: Merge branch 'develop' into bug/notification-header-rtl-button/T149386

Event Timeline

Mhurd created this task.Oct 27 2016, 11:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2016, 11:44 PM

https://github.com/wikimedia/wikipedia-ios/pull/998

Mhurd claimed this task.Oct 27 2016, 11:54 PM

Mhurd moved this task from Ready for Development to Needs Code Review on the iOS-app-v5.3.0-Welsh-Dragon board.

JoeWalsh mentioned this in rAPIOS8691112163e8: Merge branch 'develop' into bug/notification-header-rtl-button/T149386.Oct 28 2016, 12:10 PM

JoeWalsh mentioned this in rAPIOSeb4679a0bead: Merge pull request #998 from wikimedia/bug/notification-header-rtl….

JoeWalsh mentioned this in rAPIOSa646e375802d: Merge branch 'bug/notification-header-rtl-button/T149386' of github.com….Oct 28 2016, 12:15 PM

==Testing criteria==

On either iPhone or iPad
Do clean install of the app
Then before opening the app for the first time switch the device language to Hebrew
Ensure the blue button in the gray area near the top of the screen looks correct with its text and icon not overlapping the outline of the button.

It should look like this...

d762d92a-9c65-11e6-8e4f-0923d85c9284.png (1×974 px, 218 KB)

It should not look like this...

cd8e663a-9c65-11e6-8808-212a600464bc.png (1×974 px, 219 KB)

Mhurd moved this task from Needs Code Review to Needs QA on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 28 2016, 8:56 PM

• JMinor triaged this task as Low priority.Oct 28 2016, 10:35 PM

Tested on iPhone 6S (iOS 10.0.1), and Wikipedia app 5.3.0 (966). According to the attached screencap this has been fixed.

T149386.PNG (1×750 px, 132 KB)

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 30 2016, 11:05 PM

• JMinor closed this task as Resolved.Oct 31 2016, 6:01 PM

• JMinor added a project: RTL.

Restricted Application added a project: I18n. · View Herald TranscriptOct 31 2016, 6:01 PM