Page MenuHomePhabricator

Uploading an SVG file with null href refused; only http or https are allowed
Closed, ResolvedPublic

Description

Your over zealous software refuses to upload an svg with a link with a null href. It says only http or https are allowed.

This wouldnt be a problem but finding null hrefs is very hard and removing them is impossible with inkscape.
One must delete the entire object and recreate it.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2016, 8:01 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptOct 31 2016, 11:41 AM

How do the null hrefs get there in the first place?

To clarify when you mean null hrefs, you mean an element with href set to the empty string (i.e. href="" ) or do you mean something else?

Restricted Application added a subscriber: Matanya. · View Herald TranscriptOct 31 2016, 12:32 PM
Aklapper renamed this task from svg null href to Uploading an SVG file with null href refused; only http or https are allowed.Oct 31 2016, 12:52 PM

FWIW, I'm supportive of allowing href="" if they are somehow getting inserted by svg editing tools.

Okay I figured out how to remove links in inkscape. It's not done through link properties but rather through a completely separate context menu. Still others might have trouble with this and there seems to me to be no good reason why it should reject null hrefs

Change 318916 had a related patch set uploaded (by MarkTraceur):
Allow empty href in SVGs

https://gerrit.wikimedia.org/r/318916

Change 318916 merged by jenkins-bot:
Allow empty href in SVGs

https://gerrit.wikimedia.org/r/318916

matmarex closed this task as Resolved.Nov 2 2016, 11:17 AM
matmarex assigned this task to MarkTraceur.
matmarex removed a project: Patch-For-Review.
matmarex added a subscriber: matmarex.

This issue has been fixed and the fix will be deployed to Wikimedia wikis this week, 01-03 November, per https://www.mediawiki.org/wiki/MediaWiki_1.29/Roadmap.