Page MenuHomePhabricator

Linter: LintErrorsPager shouldn't rely on implicit Message::__toString()
Closed, ResolvedPublic

Description

From T148583#2813012:

LintErrorsPager - in getFieldNames() - TablePager seems to expect strings not Message Objects. Should explicitly call ->text()

Details

Related Gerrit Patches:

Event Timeline

Legoktm created this task.Nov 22 2016, 3:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2016, 3:26 AM

Change 322842 had a related patch set uploaded (by Legoktm):
LintErrorsPager: Set explicit output format on some messages

https://gerrit.wikimedia.org/r/322842

Legoktm claimed this task.Nov 22 2016, 9:18 AM

Change 322842 merged by jenkins-bot:
LintErrorsPager: Set explicit output format on some messages

https://gerrit.wikimedia.org/r/322842

Legoktm closed this task as Resolved.Nov 23 2016, 2:41 AM