Page MenuHomePhabricator
Create Task
Maniphest T151456

Thumbor original file download limit should be 4GB
Closed, ResolvedPublic
Actions

Description

As of April, Commons allows uploading files up to 4GB: https://commons.wikimedia.org/wiki/Commons:Maximum_file_size

This TIFF, for instance, is 1,69GB: https://commons.wikimedia.org/wiki/File:Andromeda_Galaxy_M31_-_Heic1502a_Full_resolution.tiff

While other limits might prevent the thumbnail from rendering (memory, time), there's no reason no to try rendering a thumbnail for that image, considering that it's an acceptable upload on Commons and that huge TIFFs like that should be resized efficiently memory-wise thanks to VIPS.

Event Timeline

• Gilles lowered the priority of this task from Medium to Low.Nov 23 2016, 2:26 PM
• Gilles created this task.
• Gilles removed a parent task: T139606: add thumbor to production infrastructure.
• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Nov 23 2016, 8:22 PM
elukey unsubscribed.Nov 24 2016, 11:30 AM
• Gilles moved this task from Backlog: Maintenance, non-prioritized to To-do: Goals prioritized current Quarter on the Performance-Team board.Dec 6 2016, 12:31 AM
• Gilles moved this task from To-do: Goals prioritized current Quarter to Backlog: Maintenance, non-prioritized on the Performance-Team board.Mar 9 2017, 11:52 AM
• Gilles added a comment.Mar 9 2017, 1:09 PM

I'm kind of ambivalent about that now. We could raise the limit, but that would make Thumbor potentially consume a lot more disk when things go wrong. And there's no guarantee that if the limit is raised, it will be capable of rendering a 4GB file's thumbnail without running out of memory first.

I guess we could raise the limit and see if it's actually possible to render thumbnails for those files. If not, it's not worth keeping the limit that high.

• Gilles added a project: Patch-For-Review.Mar 23 2017, 12:23 PM
• Gilles closed this task as Resolved.Mar 28 2017, 11:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits