Author: heuler06

Description:
When patrolling it is possible to mark a diff two times as patrolled.

Sometimes when there is many to patrol I forget/overlook what I have marked as patrolled. So I sometimes open yet patrolled diffs. Then there is the "mark as patrolled" link and I mark it as patrolled. A new site opens with the report the diff is marked as patrolled although it has been marked a few minutes ago.

Shouldn't there be a error message like "This diff is also marked as patrolled"?

I think the problem is the rcid. Only if the rcid is known you can mark a diff as patrolled. If you know the rcid it's possible to mark a diff twice as patrolled. Normally the rcid is vanished in the RCs when diff is patrolled. But as described above I do not refresh every time after marking a diff as patrolled so the rcid is still there.

I also want to draw your attention to Bug 8697 which would be also a nice feature. :)

Version: unspecified
Severity: enhancement