Page MenuHomePhabricator

ArticleSave family of hooks has unused parameters
Closed, ResolvedPublic

Description

The parameters $watch and $sectionanchor in the ArticleSave family of hooks are not used. When the hooks are called in Article->doEdit, null is passed for both parameters.

  1. These fields should be marked deprecated in the code or better yet just removed.
  2. Authors of extensions using these hooks (http://www.mediawiki.org/wiki/Category:ArticleSave_extensions) should be notified.
  3. hooks.txt should be updated.
  4. The mediawiki.org pages for the hooks should be updated.

Version: 1.13.x
Severity: enhancement
URL: http://www.mediawiki.org/wiki/Manual:Hooks/ArticleSave

Details

Reference
bz13323

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:05 PM
bzimport set Reference to bz13323.
bzimport added a subscriber: Unknown Object (MLST).

I can't find any $sectionanchor (just $section) or $watch. Seems to have been originally fixed in r14834 by Tim (changing two params to null), which haven't come back since. Going ahead and marking this FIXED, unless there's some outstanding issue.