Page MenuHomePhabricator

Quality revisions make younger versions appear as unreviewed
Closed, ResolvedPublic

Description

Author: pbirken

Description:
If one version of an article is marked as quality revision, using flagged revisions, any younger version will be presented to the reader as draft. The bug is that this is also true for sighted versions, thus rendering the process of sighting versions intransparent to the reader.

This can be seen in the URL, where one older versions is marked as quality and all the younger versions are marked as sighted.


Version: unspecified
Severity: major
URL: http://de.labs.wikimedia.org/wiki/Programmieren_mit_dBASE_PLUS:_memoEditor

Details

Reference
bz13402

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:04 PM
bzimport set Reference to bz13402.
bzimport added a subscriber: Unknown Object (MLST).

pbirken wrote:

Oh yes, and even worse, autoreviewing will not work anymore in this situation. Thus, if an editor edits a current and sighted version, it will not be automatically be flagged as sighted.

pbirken wrote:

The autoreview now works in these situation, but the rest is still as before, see http://de.labs.wikimedia.org/wiki/Computerhardware:_RAM/_Montage.

I don't understand. What else is wanted here?

pbirken wrote:

The version http://de.labs.wikimedia.org/w/index.php?title=Computerhardware:_RAM/_Montage&oldid=24904 is sighted. If I log in as editor and look at http://de.labs.wikimedia.org/wiki/Computerhardware:_RAM/_Montage I see the version mentioned, but the UI tells me it is a draft and not sighted. Or similar, if I go there as an IP and follow the link "view draft", I come to the current and sighted version, but it is shown as draft. So, it should say that this version is sighted.

This won't be an issue when $wgFlaggedRevsPrecedence is set to false.

At the moment, the quality revision is the stable version. If the current revision is not synced with revision, then the current is treated as a draft. Any working revisions that have yet to become the stable version are treated as working drafts (also that makes it clearer that they are editable).

pbirken wrote:

Brion turned it on but both this and https://bugzilla.wikimedia.org/show_bug.cgi?id=13405 do work now, but only per article after you create a new version. I mean we can live with that, but I thought I mentioned it.