Page MenuHomePhabricator

Hardcoded username in resources/js/twitter.js
Closed, ResolvedPublic

Description

I'm not really sure if anyone is fetching tweets from @envato, but I don't want them :)

As far as I can tell twitter.js isn't loaded by the Gamepress skin, so as my preference I'd just delete the file. I may be a little too fanatical about not adding trackers to a page, though.

If it's something was planned to be useful in the future, then the Twitter widget needs to be configurable and disable-able.

Event Timeline

labster created this task.Dec 25 2016, 10:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 25 2016, 10:46 AM
SamanthaNguyen moved this task from Backlog to Bugs on the Gamepress board.Dec 25 2016, 2:20 PM

Change 329530 had a related patch set uploaded (by SamanthaNguyen):
Remove unused script, make description more i18n-friendly

https://gerrit.wikimedia.org/r/329530

Change 329530 merged by jenkins-bot:
Remove unused script, make description more i18n-friendly

https://gerrit.wikimedia.org/r/329530

SamanthaNguyen closed this task as Resolved.Dec 29 2016, 12:21 AM
SamanthaNguyen edited projects, added good first task; removed Patch-For-Review.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 29 2016, 12:21 AM

Thanks for the quick turnaround!

Of course, glad to help :)