Page MenuHomePhabricator

Enhanced Recent changes / Watchlist display has unpaired parentheses
Closed, ResolvedPublic

Description

The recent r32037 broke the display of recent changes / watchlist. Especially the

@@ -492,25 +586,25 @@

			$r .= ' (';
  • if( $isnew ) {

+ if( !ChangesList::userCan($rcObj,Revision::DELETED_TEXT) ) {
+ $r .= $nchanges[$n];
+ } else if( $isnew ) {

				$r .= $nchanges[$n];
			} else {
				$r .= $this->skin->makeKnownLinkObj( $block[0]->getTitle(),
					$nchanges[$n], $curIdEq."&diff=$currentRevision&oldid=$oldid" );
			}
  • $r .= ') . . '; - if( $wgRCShowChangedSize ) {
    1. Character difference $chardiff = $rcObj->getCharacterDifference( $block[ count( $block ) - 1 ]->mAttribs['rc_old_len'], $block[0]->mAttribs['rc_new_len'] ); if( $chardiff == '' ) {
  • $r .= ' (';

+ $r .= ') ';

				} else {
					$r .= ' ' . $chardiff. ' . . ';
				}
  • }

+ }

  1. History $r .= '(' . $this->skin->makeKnownLinkObj( $block[0]->getTitle(),

part: Because getCharacterDifference() result already contains parentheses, the result of this change is that a line in Enhanced RC/WL contains an unpaired paren (“(2 changes (-8)”).

(Also, I don’t consider literal “style=font-size:95%;” to be a great idea, but that is not that important.)


Version: unspecified
Severity: minor

Details

Reference
bz13440

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:06 PM
bzimport set Reference to bz13440.
bzimport added a subscriber: Unknown Object (MLST).

Fixed in r32194. Hard-coded font size was a testing relic; removed that too.