Page MenuHomePhabricator

Special:Reviewedpages has one level too many
Closed, ResolvedPublic

Description

Author: pbirken

Description:
The dropdown menu for Special:Reviewedpages has three levels, (sighted, quality and featured), although the wiki has only two levels (sighted and quality). Furthermore, the quality versions are listed under the option featured (http://de.labs.wikimedia.org/w/index.php?namespace=0&level=2&title=Spezial%3AReviewedpages) and not under quality.


Version: unspecified
Severity: minor
URL: http://de.labs.wikimedia.org/w/index.php?namespace=0&level=1&title=Spezial%3AReviewedpages

Details

Reference
bz13506

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:04 PM
bzimport set Reference to bz13506.
bzimport added a subscriber: Unknown Object (MLST).

pbirken wrote:

The number of levels has been fixed, but they do not correspond to the correct things. More precisely,

i) The link to level 0 http://de.labs.wikimedia.org/w/index.php?namespace=0&level=0&title=Spezial%3AReviewedpages corresponds to selecting sighted in the dropdown menu. This is correct.

ii) The link to level 1 http://de.labs.wikimedia.org/w/index.php?namespace=0&level=1&title=Spezial%3AReviewedpages corresponds to selecting quality in the dropdown menu. So this list should show the quality versions, but it is empty.

iii) The link to level 2 http://de.labs.wikimedia.org/w/index.php?namespace=0&level=2&title=Spezial%3AReviewedpages corresponds to the now removed option in the dropdown menu and this list is what should be shown for level 1.

Level 2 does not exist, so it defaults to 0. The levels are now cumulative as of r32505.

(In reply to comment #3)

Level 2 does not exist, so it defaults to 0. The levels are now cumulative as
of r32505.

Actually, just reverted that. The real problem here is that the "featured status" change is not retroactive. Newer quality reviews should show up on the list already.

pbirken wrote:

You're right, the level 1 currently shows one page which has been flagged since the last changes from SVN went active. I'm sorry about the extra work :-(