solve_disambiguation.py: Fix or remove the unreachable line
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dalba
	Jan 15 2017, 11:29 AM

Description

Line 944 of solve disambugation.py is unreachable.

As @Xqt said:

The easiest way is to remove the continue statements inside the if/else-clauses above and put it below. But is it needed to print that?

Details

	Subject	Repo	Branch	Lines +/-
	[cleanup] Remove unreachable line in solve_disambiguation.py	pywikibot/core	master	+76 -57

Customize query in gerrit

Related Objects

Mentioned In: rPWBC4e214f0fa14f: [cleanup] Remove unreachable line in solve_disambiguation.py
T203395: (Re)move unused code reported by Vulture

Event Timeline

Dalba created this task.Jan 15 2017, 11:29 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 15 2017, 11:29 AM

Dvorapa mentioned this in T203395: (Re)move unused code reported by Vulture.Oct 8 2018, 8:20 PM

Xqt triaged this task as Low priority.Oct 8 2018, 8:37 PM

Change 638071 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [cleanup] Remove unreachable line in solve_disambiguation.py

https://gerrit.wikimedia.org/r/638071

gerritbot added a project: Patch-For-Review.Nov 2 2020, 11:28 AM

Xqt claimed this task.Nov 2 2020, 11:29 AM

Change 638071 merged by jenkins-bot:
[pywikibot/core@master] [cleanup] Remove unreachable line in solve_disambiguation.py

https://gerrit.wikimedia.org/r/638071

Xqt mentioned this in rPWBC4e214f0fa14f: [cleanup] Remove unreachable line in solve_disambiguation.py.Nov 5 2020, 9:22 AM

Xqt closed this task as Resolved.Nov 5 2020, 9:41 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2020, 10:10 AM

solve_disambiguation.py: Fix or remove the unreachable lineClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

solve_disambiguation.py: Fix or remove the unreachable line
Closed, ResolvedPublic
Actions