Page MenuHomePhabricator

$wgShowUpdatedMarker requirement for $wgEnotifWatchlist is inconsistent and undocumented
Closed, ResolvedPublic

Description

Author: webboy

Description:
Patch 1: Consistently require $wgEnotifWatchlist to be true

Currently, $wgShowUpdatedMarker requires $wgEnotifWatchlist to be true to function correctly. But this requirement is not documented and not consistently programmed.

Besides extra database queries this is causing a bug:

When you first enable and then disable $wgEnotifUserTalk and $wgEnotifWatchlist and leave $wgShowUpdatedMarker unchanged (default: true) any left over "updated since my last visit" marks won't go away.

There are two solutions:
1: Consistently require $wgEnotifWatchlist to be true, see patch 1.
2: Completely remove the $wgEnotifWatchlist requirement, see patch 2.

I'd prefer solution 2 because it's more flexible.


Version: 1.13.x
Severity: normal

attachment bug-wgShowUpdateMarker-requireEnotifWatchlist.patch ignored as obsolete

Details

Reference
bz13916

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:09 PM
bzimport set Reference to bz13916.
bzimport added a subscriber: Unknown Object (MLST).

webboy wrote:

Patch 2: Completely remove the $wgEnotifWatchlist requirement

Note: when applying this patch, $wgShowUpdatedMarker should probably be set to false (default: true) on large wikis.

attachment bug-wgShowUpdateMarker-norequire.patch ignored as obsolete

webboy wrote:

Updated patch

Partly fixed by r35002 (solution 2).

Attached updated patch.

Attached: