Page MenuHomePhabricator
Create Task
Maniphest T159537

[BUG] Share-A-Fact Broken for Articles without Lead Images
Closed, ResolvedPublic
Actions

Description

Steps to reproduce

  1. Open any article without a lead image
  2. Highlight Text in article
  3. Tap "Share-A-Fact"

Expected results

Share interface should appear

Actual results

Nothing

Screenshots

N/A (outcome is nothing)

Environments observed

App version: 5.4.0 1082
OS versions: 10..2.1
Device model: iPhone 7 Plus
Device language: English

Related Objects

Event Timeline

• Fjalapeno created this task.Mar 3 2017, 3:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2017, 3:37 PM
• JMinor triaged this task as Low priority.Mar 3 2017, 6:16 PM
• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.4.0-Hiking-Boot board.
• AMroczkowski claimed this task.Mar 3 2017, 8:38 PM
• AMroczkowski moved this task from Ready for Development to Doing on the iOS-app-v5.4.0-Hiking-Boot board.
• AMroczkowski added a comment.Mar 3 2017, 9:13 PM

If there is no lead image, I assume we just remove the "Share as image" option and only have "Share as text"?

• AMroczkowski added a comment.Mar 3 2017, 9:38 PM

Screenshot 2017-03-03 16.37.25.png (1×974 px, 303 KB)

Diffusion mentioned this in rAPIOSe9351aa29de8: Merge branch 'develop' into bug/T159537-share-a-fact-without-lead-image.Mar 3 2017, 9:43 PM
• AMroczkowski moved this task from Doing to Needs Code Review on the iOS-app-v5.4.0-Hiking-Boot board.Mar 3 2017, 9:49 PM
JoeWalsh mentioned this in rAPIOSb23a71df8b47: Merge pull request #1241 from wikimedia/bug/T159537-share-a-fact-without-lead….Mar 3 2017, 9:49 PM
• AMroczkowski moved this task from Needs Code Review to Needs Design Review on the iOS-app-v5.4.0-Hiking-Boot board.Mar 3 2017, 10:02 PM
• AMroczkowski added a subscriber: cmadeo.

@JMinor @cmadeo throwing this in Needs Design Review. I'm told the black background was the way it used to be but wanted to get signify

• JMinor added a comment.Mar 3 2017, 10:42 PM

@AMroczkowski suggest we use the black background. Its not the most useful feature, but it was the status quo.

cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v5.4.0-Hiking-Boot board.Mar 3 2017, 11:14 PM

Agreed, we'll used the black background for now. I think we're planning on touching this during design debt.

Nicholas.tsg subscribed.Mar 4 2017, 11:26 PM

Testing on iPhone 7 with iOS 10.2 (this is the closest I have to an iPhone 7 Plus) and Wikipedia app 5.4.0 (1083).

According to this screencap the share interface appears after I follow the steps above so this is fixed:

T159537.PNG (1×750 px, 467 KB)

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.4.0-Hiking-Boot board.Mar 4 2017, 11:27 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Mar 6 2017, 7:36 PM
• JMinor closed this task as Resolved.Mar 6 2017, 9:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL