Page MenuHomePhabricator
Create Task
Maniphest T159623

UX issue: Button for uploading avatar shouldn't show until a user selects an avatar
Closed, ResolvedPublic
Actions

Description

The button for uploading an avatar (Upload file) which will submit the avatar to the wiki shouldn't show until after a user has selected it. Their labels can be easily mixed together since these buttons are quite close together as well as "Upload file" and "Choose file" have similar meanings. You can say you can choose your avatar and then submit it, and you can say you can upload your avatar and then upload to the wiki.

Details

SubjectRepoBranchLines +/-
Don't show the "Upload file" button on Special:UploadAvatar until the user selects a filemediawiki/extensions/SocialProfilemaster+16 -0
Customize query in gerrit

Related Objects

Event Timeline

SamanthaNguyen created this task.Mar 4 2017, 10:38 PM
SamanthaNguyen moved this task from Backlog to Feedback on the SocialProfile board.Apr 10 2017, 3:14 AM
SamanthaNguyen unsubscribed.Jun 30 2018, 8:06 PM
gerritbot subscribed.Jul 8 2018, 1:02 PM

Change 444439 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/SocialProfile@master] Don't show the "Upload file" button on Special:UploadAvatar until the user selects a file

https://gerrit.wikimedia.org/r/444439

gerritbot added a project: Patch-For-Review.Jul 8 2018, 1:02 PM
gerritbot added a comment.Jul 8 2018, 11:07 PM

Change 444439 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Don't show the "Upload file" button on Special:UploadAvatar until the user selects a file

https://gerrit.wikimedia.org/r/444439

ashley closed this task as Resolved.Jul 8 2018, 11:10 PM
ashley claimed this task.
ashley removed a project: Patch-For-Review.
ashley mentioned this in T183072: SocialProfile - Provide a safe fallback for when user doesn't choose any avatar and presses "upload" on Special:UploadAvatar.Sun, Jun 2, 9:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL