Page MenuHomePhabricator

Allow redo search in map after single search result
Closed, ResolvedPublic

Description

Tap on a search suggestion
Move or zoom the map

I should see the "Redo search in map" button and when I tap it I should see the Top Articles pins in my current map view and the search text should reset to Top Articles.

Event Timeline

ABorbaWMF subscribed.

Added to testcases. Moving to Needs QA.

Tested and appears to work. I did a bunch of redo searches on places, with and without location enabled.

iPhone 7+ - iOS10.2.1
iPad Mini 2 Retina - 10.2.1

@Nicholas.tsg Can you please take a look on your iOS devices. Thanks!

Tested on iPhone 7 (iOS 10.2.1) only due to an error that came up when I was testing. I didn't so much do a "search suggestion" as I picked a random place to search (Yerba Buena Center for the Arts) but instead of "Redo search in map" I got a "Search this Article" button and tapping it gave me an error. So I might've misunderstood the steps but anyway testing did not work as expected:

T159747 Part 1 (Search).PNG (1×750 px, 1 MB)
T159747 Part 2 (Search this Article instead of Redo search in map).PNG (1×750 px, 1 MB)
T159747 Part 3 (Error).PNG (1×750 px, 1 MB)

I took a look at the behavior and I think I was able to reproduce what @Nicholas.tsg saw.

Steps:

  1. Tap places
  2. Perform a search (Example: washington monument)
  3. Zoom in onto the article pin (slightly)
  4. Tap search this area

Expected Result: The search result is redisplayed and centered

Actual Result: No results error message appears

I think this is a different minor bug and we can open a separate ticket for it. It appears the feature is working. @Nicholas.tsg - Can you please confirm this is the behavior you saw?